Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Faraday 2.x, which requires Ruby 2.6+ #99

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Move to Faraday 2.x, which requires Ruby 2.6+ #99

merged 3 commits into from
Nov 30, 2022

Commits on Jun 9, 2022

  1. Use bundler-cache option in GitHub Actions 

    This avoids the need to install bundler and adds caching between runs.
    @ekohl
    ekohl committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    c20482a View commit details
    Browse the repository at this point in the history

  2. Remove redundant conditionals on RUBY_VERSION 

    The minimum version was declared as Ruby 2.4 so these conditionals do
not make sense.

Fixes: 05a4e77
    @ekohl
    ekohl committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    66df7fe View commit details
    Browse the repository at this point in the history

  3. Move to Faraday 2.x 

    It does not attempt to support Faraday 1.x as well because dependency
wise it would be impossible to pull in the correct middleware. That is
why a hard switch was made.

This moves the minimum Ruby version to 2.6 since that's what Faraday 2
has as the minimum version.

It also pulls in faraday-follow_redirects, which was previously part of
Faraday itself.

The registration is now done without a lamba since it's allowed to pass
in a constant.

CI is also modified to test on all actual Ruby version that currently
match the required_ruby_version in the gemspec. That is, 2.6 - 3.1.
    @ekohl
    ekohl committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    06102bc View commit details
    Browse the repository at this point in the history