Skip to content

Commit

Permalink
(CAT-2007) Remove VERIFY_PEER skip on Windows
Browse files Browse the repository at this point in the history
Add `bigdecimal` as development dependency
  • Loading branch information
david22swan committed Sep 17, 2024
1 parent afeb5aa commit d3e5d95
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions lib/pdk/util/vendored_file.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ def download_file
uri = URI.parse(url)
http = Net::HTTP.new(uri.host, uri.port)
http.use_ssl = true
# TODO: Get rid of this
http.verify_mode = OpenSSL::SSL::VERIFY_NONE if Gem.win_platform?
request = Net::HTTP::Get.new(uri.request_uri)
response = http.request(request)

Expand Down
2 changes: 2 additions & 0 deletions pdk.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,7 @@ Gem::Specification.new do |spec|
spec.add_runtime_dependency 'json_pure', '~> 2.6.3'
spec.add_runtime_dependency 'pathspec', '~> 1.1'

spec.add_development_dependency 'bigdecimal'

Check failure on line 53 in pdk.gemspec

View workflow job for this annotation

GitHub Actions / spec (ruby 2.7) / spec

Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile.

Check failure on line 53 in pdk.gemspec

View workflow job for this annotation

GitHub Actions / spec (ruby 3.2) / spec

Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile.

spec.metadata['rubygems_mfa_required'] = 'true'
end
1 change: 0 additions & 1 deletion spec/unit/pdk/util/vendored_file_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
allow(Net::HTTP::Get).to receive(:new).with(anything).and_return(mock_request)
allow(Net::HTTP).to receive(:new).with(any_args).and_return(mock_http)
allow(mock_http).to receive(:use_ssl=).with(anything)
allow(mock_http).to receive(:verify_mode=).with(anything)
end

let(:download_error) { described_class::DownloadError }
Expand Down

0 comments on commit d3e5d95

Please sign in to comment.