Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented update os support #222

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implemented update os support #222

wants to merge 1 commit into from

Conversation

alex501212
Copy link
Contributor

I noticed that the update_os_support task has no functionality so I have implemented this task

I added the new update_os_support method to utils.rb and a supported_os_list.yaml in the conf folder.

This update_os_support will update the operating systems supported in a module's metadata.json and update it to match the OSes in the supported_os_list

@alex501212 alex501212 requested review from logicminds and a team as code owners October 8, 2024 15:50
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.30%. Comparing base (1698cbf) to head (acb3757).

Files with missing lines Patch % Lines
lib/pdksync/utils.rb 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   45.55%   45.30%   -0.26%     
==========================================
  Files          10       10              
  Lines        1216     1225       +9     
==========================================
+ Hits          554      555       +1     
- Misses        662      670       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@logicminds
Copy link
Collaborator

This is a good idea. But in terms of adding the "right" os support there isn't really a one size fits all. Every module probably has something different. A better approach would allow the user to:

  1. select from a list of support templates that pdksync has predefined
  2. allow the user to override specific groups of operating systems.

@alex501212 alex501212 marked this pull request as draft October 15, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants