Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Install Puppet Server Task #277

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Oct 28, 2024

Summary

This commit corrects a syntax issue causing the provision::install_puppetserver task to fail on the Ubuntu platform.

Additional Context

The arguments for the fetch_codename() function are currently grouped to be passed in as a single argument instead of $collection and $platform separately. As a result the task errors out and states there are no builds for Ubuntu.

Related Issues

Looks like the issue was introduced in this commit.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@coreymbe coreymbe requested a review from a team as a code owner October 28, 2024 15:51
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Doesn't seem to have triggered a mend check this time so it should be fine

@david22swan david22swan merged commit 08e9187 into puppetlabs:main Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants