(FM-7597) RSAPI Transport register function and Schema validation #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
suggested changes
Dec 7, 2018
| raise Puppet::DevError, 'TransportSchemaDef requires definition to be a Hash' unless definition.is_a?(Hash) | ||
| super(definition, :connection_info) | ||
| end | ||
| end |
There was a problem hiding this comment.
Given how small TransportSchemaDef and TypeDefinition have become I'd pref to have them all in one file:
module Puppet::ResourceApi
# pre-declare class
class BaseTypeDefinition; end
class Puppet::ResourceApi::TypeDefinition < Puppet::ResourceApi::BaseTypeDefinition
# ...
...
..
class BaseTypeDefinition
# the rest
| # Provides accessor methods for the type being provided | ||
| class Puppet::ResourceApi::TransportSchemaDef < Puppet::ResourceApi::BaseTypeDefinition | ||
| def initialize(definition) | ||
| raise Puppet::DevError, 'TransportSchemaDef requires definition to be a Hash' unless definition.is_a?(Hash) |
There was a problem hiding this comment.
duplicate check - if you're doing this because of the class name in the error message, use self.class.name in the base class.
| # Remote target transport API | ||
| module Puppet::ResourceApi::Transport | ||
| class << self | ||
| attr_reader :transports |
There was a problem hiding this comment.
exposing the transports like this will allow folks to directly interact with the hash and add/modify/delete entries without validation. there is no need for the accessor yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.