(PDK-508) implement autorequire and friends #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
pdk-508-autofriends
branch
3 times, most recently
from
2b2185b
to
b2ea82d
Compare
DavidS
force-pushed
the
pdk-508-autofriends
branch
2 times, most recently
from
dffac68
to
bc43895
Compare
By pulling in puppetlabs_spec_helper into the main project, we can run tests for the `test_module` in the main test suite without friction. This makes it easier and quicker to run this kind of tests. See the next commits for usage. This requires puppetlabs/puppetlabs_spec_helper#234
This is a separate commit to make it easier to see what was changed for the test.
The spec/classes/autorequire_cycle_spec.rb test shows that the autorelations implementation of the Resource API does build relations. Since rspec-puppet doesn't provide matching on compile errors, this builds a test case that compiles when make_cycle is false, thereby proving that there is no error in the manifest, but fails with a dependency cycle error when make_cycle is set to true.
DavidS
force-pushed
the
pdk-508-autofriends
branch
from
bc43895
to
8cbec7f
Compare
da-ar
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.