(PDK-911) Fix handling of ensure values from symbols to strings
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
added a commit
to DavidS/pdk-templates
that referenced
this pull request
Apr 6, 2018
Requires to be synchronised with puppetlabs/puppet-resource_api#55
Tripping over puppet's behaviour for handling newvalue values, rsapi would accidentally pass symbols for `Enum[absent, present]` ensures. The unit and integration tests did not agree on whether `absent` and `present` should be strings or symbols. Puppet itself is calling for a string as a value for `Enum`s, and in the implementation those two were only symbols because of a special case in the setup of the two. This commit fixes this behaviour to always use string. This makes it consistent with the rest of the API, and reduces the amount of noise developers have to remember when working with values passed from us.
DavidS
force-pushed
the
pdk-911-string-symbol-straightening
branch
from
2384296
to
6639dd0
Compare
da-ar
approved these changes
Apr 6, 2018
tphoney
reviewed
Apr 6, 2018
| @@ -210,7 +210,11 @@ def feature_support?(feature) | |||
|
|
|||
| case options[:type] | |||
| when 'Enum[present, absent]' | |||
| Puppet::ResourceApi.def_newvalues(self, param_or_property, :absent, :present) | |||
| Puppet::ResourceApi.def_newvalues(self, param_or_property, 'absent', 'present') | |||
There was a problem hiding this comment.
the real bummer is the next line. this here is only cosmetics
|
👍 lets do eet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tripping over puppet's behaviour for handling newvalue values, rsapi
would accidentally pass symbols for
Enum[absent, present]ensures.The unit and integration tests did not agree on whether
absentandpresentshould be strings or symbols. Puppet itself is calling fora string as a value for
Enums, and in the implementation those twowere only symbols because of a special case in the setup of the two.
This commit fixes this behaviour to always use string. This makes it
consistent with the rest of the API, and reduces the amount of noise
developers have to remember when working with values passed from us.