(PDK-895) basic array support #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
pdk-895-basic-array-support
branch
from
f36a7ea
to
3e052ae
Compare
This is not needed anymore
DavidS
force-pushed
the
pdk-895-basic-array-support
branch
from
3e052ae
to
770310f
Compare
|
The openssl change improves test times on appveyor by approximately a minute out of six and a half. |
DavidS
force-pushed
the
pdk-895-basic-array-support
branch
from
770310f
to
6d3ed67
Compare
Use the new `mungify` function to replace the entire validate/munge cycle on Parameters and Properties. This includes a couple of hacks to not break other parts of puppet. Also includes some fixes were test data for the patterns did not actually match the expectations (either Integers instead of Strings, or only seven digits, instead of eight).
DavidS
force-pushed
the
pdk-895-basic-array-support
branch
from
6d3ed67
to
e6ce04d
Compare
DavidS
added a commit
to DavidS/puppet-resource_api
that referenced
this pull request
Apr 10, 2018
Most of the work for this has been done in puppetlabs#59. This adds some tests to verify the functionality.
DavidS
added a commit
to DavidS/puppet-resource_api
that referenced
this pull request
Apr 10, 2018
All the work for this has been done in puppetlabs#59. This adds some tests to verify the functionality.
DavidS
added a commit
to DavidS/puppet-resource_api
that referenced
this pull request
Apr 10, 2018
All the work for this has been done in puppetlabs#59. This adds some tests to verify the functionality.
DavidS
added a commit
to DavidS/puppet-resource_api
that referenced
this pull request
May 22, 2018
The mungify introduced in puppetlabs#59 would also affect strings passed in as parameters through manifests (e.g. using `puppet apply` or the agent), masking input type errors. This change fixes the behaviour so that munging is only happening when the runtime environment is actually puppet resource. Of course, long-term it would be better to have the CLI itself mungify inputs from the CLI. Such an implementation could provider more specific error messages, and reduce code complexity here. For now, this solution works across all puppet versions, and provides the same functionality. versions.
DavidS
added a commit
to DavidS/puppet-resource_api
that referenced
this pull request
May 22, 2018
The mungify introduced in puppetlabs#59 would also affect strings passed in as parameters through manifests (e.g. using `puppet apply` or the agent), masking input type errors. This change fixes the behaviour so that munging is only happening when the runtime environment is actually puppet resource. Of course, long-term it would be better to have the CLI itself mungify inputs from the CLI. Such an implementation could provider more specific error messages, and reduce code complexity here. For now, this solution works across all puppet versions, and provides the same functionality. versions.
DavidS
added a commit
to DavidS/puppet-resource_api
that referenced
this pull request
May 22, 2018
The mungify introduced in puppetlabs#59 would also affect strings passed in as parameters through manifests (e.g. using `puppet apply` or the agent), masking input type errors. This change fixes the behaviour so that munging is only happening when the runtime environment is actually puppet resource. Of course, long-term it would be better to have the CLI itself mungify inputs from the CLI. Such an implementation could provider more specific error messages, and reduce code complexity here. For now, this solution works across all puppet versions, and provides the same functionality. versions.
DavidS
added a commit
to DavidS/puppet-resource_api
that referenced
this pull request
May 22, 2018
The mungify introduced in puppetlabs#59 would also affect strings passed in as parameters through manifests (e.g. using `puppet apply` or the agent), masking input type errors. This change fixes the behaviour so that munging is only happening when the runtime environment is actually puppet resource. Of course, long-term it would be better to have the CLI itself mungify inputs from the CLI. Such an implementation could provide more specific error messages, and reduce code complexity here. For now, this solution works across all puppet versions, and provides the same functionality. versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.