-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PDK-746) have a SimpleProvider for simple cases #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 98.36% 98.47% +0.11%
==========================================
Files 8 9 +1
Lines 305 328 +23
==========================================
+ Hits 300 323 +23
Misses 5 5
Continue to review full report at Codecov.
|
DavidS
force-pushed
the
pdk-746-simpleprovider
branch
2 times, most recently
from
January 4, 2018 13:46
e07b78d
to
49951e4
Compare
This removes some of the "tedium" of writing a provider, when the resource does not benefit from batching, or asynchronous processing.
For some reason appveyor did not report back anymore to PRs, although it was still building. I've recreated the project to try to fix the link, but this also required updating the badge here.
DavidS
force-pushed
the
pdk-746-simpleprovider
branch
4 times, most recently
from
January 4, 2018 14:06
20035bf
to
b932ed9
Compare
license_finder 4.0 and onwards contain a symlink that does not install with older rubugem versions. See pivotal/LicenseFinder#445 for a upstream fix
DavidS
force-pushed
the
pdk-746-simpleprovider
branch
from
January 4, 2018 15:45
f23d057
to
dadbd22
Compare
codecov has the better result rendering (specifically diff-coverage), and does not spam github with comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the "tedium" of writing a provider, when the resource
does not benefit from batching, or asynchronous processing.