Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PDK-746) have a SimpleProvider for simple cases #8

Merged
merged 4 commits into from
Jan 5, 2018

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Jan 4, 2018

This removes some of the "tedium" of writing a provider, when the resource
does not benefit from batching, or asynchronous processing.

@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #8 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   98.36%   98.47%   +0.11%     
==========================================
  Files           8        9       +1     
  Lines         305      328      +23     
==========================================
+ Hits          300      323      +23     
  Misses          5        5
Impacted Files Coverage Δ
lib/puppet/resource_api/simple_provider.rb 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f4a35...45a7829. Read the comment docs.

@DavidS DavidS force-pushed the pdk-746-simpleprovider branch 2 times, most recently from e07b78d to 49951e4 Compare January 4, 2018 13:46
This removes some of the "tedium" of writing a provider, when the resource
does not benefit from batching, or asynchronous processing.
For some reason appveyor did not report back anymore to PRs, although
it was still building. I've recreated the project to try to fix the link,
but this also required updating the badge here.
@DavidS DavidS force-pushed the pdk-746-simpleprovider branch 4 times, most recently from 20035bf to b932ed9 Compare January 4, 2018 14:06
license_finder 4.0 and onwards contain a symlink that does not install
with older rubugem versions.

See pivotal/LicenseFinder#445 for a upstream fix
codecov has the better result rendering (specifically diff-coverage), and
does not spam github with comments.
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@puppetlabs puppetlabs deleted a comment from coveralls Jan 5, 2018
@DavidS DavidS merged commit 45a7829 into puppetlabs:master Jan 5, 2018
@DavidS DavidS deleted the pdk-746-simpleprovider branch January 5, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant