(PDK-1007) implement enough to support purge=>true #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidS
force-pushed
the
pdk-1007-fix-purge
branch
2 times, most recently
from
6492278
to
bf7c185
Compare
|
The code coverage failure seems to be only empty lines. |
DavidS
force-pushed
the
pdk-1007-fix-purge
branch
from
6310c97
to
f0605ca
Compare
|
rebased to master |
da-ar
reviewed
Jun 11, 2018
| expect(stdout_str.strip).to match %r{ensure\s*=> \'present\'} | ||
| expect(status).to eq 0 | ||
| end | ||
| # it 'returns the match if title matches a namevar value' do |
There was a problem hiding this comment.
perhaps a comment to say why this is commented out rather than removed?
spec/acceptance/namevar_spec.rb
Outdated
| expect(stdout_str.strip).to match %r{ensure\s*=> \'present\'} | ||
| expect(status).to eq 0 | ||
| end | ||
| # it 'returns the match if title matches a namevar value' do |
| @@ -1,7 +1,7 @@ | |||
| # Puppet::ResourceApi [](https://travis-ci.org/puppetlabs/puppet-resource_api) [](https://ci.appveyor.com/project/puppetlabs/puppet-resource-api/branch/master) | |||
| [](https://codecov.io/gh/puppetlabs/puppet-resource_api) | |||
|
|
|||
| This is an implementation of the [Resource API](https://github.com/DavidS/puppet-specifications/blob/resourceapi/language/resource-api/README.md) proposal. Find a working example of a new-style provider in the [experimental puppetlabs-apt branch](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/provider/apt_key2/apt_key2.rb). There is also the corresponding [type](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/type/apt_key2.rb), [provider](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/provider/apt_key2/apt_key2.rb), and [new unit tests](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/spec/unit/puppet/provider/apt_key2/apt_key2_spec.rb) for 100% coverage. | |||
| This is an implementation of the [Resource API](https://github.com/puppetlabs/puppet-specifications/blob/master/language/resource-api/README.md) proposal. Find a working example of a new-style provider in the [experimental puppetlabs-apt branch](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/provider/apt_key2/apt_key2.rb). There is also the corresponding [type](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/type/apt_key2.rb), [provider](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/lib/puppet/provider/apt_key2/apt_key2.rb), and [new unit tests](https://github.com/DavidS/puppetlabs-apt/blob/resource-api-experiments/spec/unit/puppet/provider/apt_key2/apt_key2_spec.rb) for 100% coverage. | |||
There was a problem hiding this comment.
Looks like another reference on line 179 that requires updating as well
This commit adds a property to make sure that what we get output is what we asked for in the first place.
To allow the `resources` type to purge resource instances, the `instances` method needs to return full `Puppet::Type` object instances. This commit changes the Resource API's definition of the `instances` method to do so, and fix up all adjacent issues. As of yet, this code still fails tests because it is not passing on the "current" values to the `Puppet::Type` instances returned. Instead `get` gets called through retrieve for each individual instance, causing both performance issues and test failures.
With `--strict=error`, `puppet resource` would not work. The fix of PDK-1007 now uncovered this. Therefore this commit only checks that `puppet resource` succeeds on `--strict=off`.
With the last few changes the rsapi would call into get multiple times for a type during a single run. This commit now pulls the retrieval of the current state into `refresh_current_state` and leaves the caching vs calling decision up to the caller. As a side-effect the strict get-returns-canonical-values check now runs at a time when puppet is not aborting the transaction for errors, and the "exercising a device provider using `puppet resource` with strict checking at error level deals with canonicalized resources correctly" test case does not produce a non-zero exit code anymore. Since now the state of the resource is correctly cached, the "exercising simple_get_filter" test needed to be adjusted to use noop to display the test result value.
Since `instances` now returns full `Puppet::Type` instances, this can be removed. `ResourceShim`s are still used in `to_resource` to work around the various manifest rendering bugs of the base implementation.
DavidS
force-pushed
the
pdk-1007-fix-purge
branch
from
f0605ca
to
e379a7a
Compare
|
Addressed comments and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.