Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add xbps used by voidlinux as a package provider #8976

Merged
merged 1 commit into from
May 30, 2024

Conversation

Animeshz
Copy link
Contributor

@Animeshz Animeshz commented Jan 5, 2023

I wanted to use puppet on void-linux, so this PR adds the package provider for xbps.

Let me know if any changes has to be made :)

@Animeshz Animeshz requested a review from a team as a code owner January 5, 2023 20:19
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2023

CLA assistant check
All committers have signed the CLA.

@Animeshz Animeshz changed the title Add xbps (used by voidlinux) as a package provider (maint) Add xbps used by voidlinux as a package provider Jan 6, 2023
@Animeshz
Copy link
Contributor Author

@joshcooper @tvpartytonight (just pinging).

Rebased on tip of main branch removing conflicts, can someone please review.

locales/puppet.pot Outdated Show resolved Hide resolved
@joshcooper
Copy link
Contributor

Hi @Animeshz thanks for your pull request! I had a few minor comments, but generally looked great.

@joshcooper joshcooper added triaged Jira issue has been created for this enhancement New feature or request labels Nov 15, 2023
@Animeshz
Copy link
Contributor Author

I had a few minor comments, but generally looked great.

I got those addressed (and tested basic functionality on local machine), let me know if anything else has to be done.

@Animeshz
Copy link
Contributor Author

Sorry I didn't performed lint checks. I've addressed those nuances now.

And tests should now pass. Please have a look 😄

@joshcooper joshcooper removed the triaged Jira issue has been created for this label Nov 29, 2023
@joshcooper
Copy link
Contributor

closing and reopening to trigger checks

@joshcooper joshcooper closed this Mar 13, 2024
@joshcooper joshcooper reopened this Mar 13, 2024
@joshcooper
Copy link
Contributor

@Animeshz can you fix the rubocop checks by running bundle exec rubocop -a and squash your commits?

@Animeshz
Copy link
Contributor Author

Animeshz commented Mar 13, 2024

It used to pass all checks that time, seems like rubocop rules have been changed since then.

24-03-13-12h10m36s

Let me rebase, fix and squash up real quick.

EDIT: Done, checked rake tests and rubocop suggestions.

24-03-13-12h30m20s

locales/puppet.pot Outdated Show resolved Hide resolved
lib/puppet/provider/package/xbps.rb Outdated Show resolved Hide resolved
lib/puppet/provider/package/xbps.rb Outdated Show resolved Hide resolved
lib/puppet/provider/package/xbps.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Animeshz this will be released in the next puppet 8 version

@joshcooper joshcooper merged commit c260871 into puppetlabs:main May 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants