Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust dead documentation link #2520

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ThomasMinor
Copy link
Contributor

Summary

Fix a dead documentation link, the puppetlabs.github.io pages seem to be gone.

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2024

CLA assistant check
All committers have signed the CLA.

@ThomasMinor
Copy link
Contributor Author

It seems the link is still broken, will the content be available at some time?
If yes, this PR could be closed.

@ThomasMinor
Copy link
Contributor Author

Hi @ekohl, @bastelfreak, @smortex,
the link is still broken. If it will be fixed sometime we can close this PR, otherwise think about approving it.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasMinor this is currently an issue with all puppetlabs module. I asked on slack if this file is managed automatically from some internal tooling (it does not seems to be managed from pdk-templates) or if opening one PR / repo make sense but got no answer. I pinged them again.

AFAIAC, this new URL in this PR is fine, and if we have no news from people at puppetlabs, I am fine with replacing this broken link with a working one with similar content like this one.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Thx smortex for the PR feedback!

Co-authored-by: Romain Tartière <[email protected]>
@ThomasMinor
Copy link
Contributor Author

Any News on this topic?

@ekohl
Copy link
Collaborator

ekohl commented Nov 12, 2024

@ThomasMinor you're pinging the non-Perforce people but IMHO they are responsible for the CONTRIBUTING.md file. Given their recent blog post I'm not sure if they actually want people to contribute at all so I'm not going to be helpful here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants