Enable and correct spec files for lbmethods #2551
Conversation
traylenator
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
|
IIRC there's a check in rubocop-rspec that finds these. Clearly there's a need for it. |
A selection of spec file were missing the correct extension `_spec.rb` and presumably never being executed.
traylenator
changed the title
https://www.rubydoc.info/gems/rubocop-rspec/1.0/RuboCop/Cop/RSpec/FileName That seems a lot stricter. |
| context 'on a Debian OS' do | ||
| include_examples 'Debian 11' | ||
|
|
||
| context 'with Apache version >= 2.4' do |
There was a problem hiding this comment.
We don't have any Apache < 2.4 anymore, so you can simply all files by dropping that.
There was a problem hiding this comment.
You start running into api change with this since apache::apache_version has to be set to apache::mod::lbmethod_heartbeat currently If you remove the necessity for that parameter and in fact the parameter completely then that's the api change.
While that's probably a good thing a separate patch I'd say.
There was a problem hiding this comment.
Looks like I missed that in cedd45b. We already dropped it from apache::balancer and everywhere else. Is it really breaking the API? The whole $apache::apache_version parameter doesn't exist anymore, which is probably why it's broken by default.
I've opened #2552 to resolve it in a compatible way. I'd prefer to base this PR on that.
There was a problem hiding this comment.
I'd prefer to base this PR on that.
Not the other way around.
- Add tests to confirm current behaviours.
- Change behaviour using tests to confirm that change of behaviour.
Summary
A selection of spec file were missing the correct extension
_spec.rband presumably never being executed.Subsequently most need updating since they were a copy and paste of one of them.
Checklist
puppet apply)