Wsgi hash documentation #2553
Open
Wsgi hash documentation #2553
+13
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virot
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
|
|
smortex
reviewed
Jun 10, 2024
smortex
reviewed
Jun 10, 2024
manifests/vhost.pp
Outdated
Comment on lines
1193
to
1194
| # processes => '2', | ||
| # threads => '15', |
There was a problem hiding this comment.
Do you know if we can use integers? If so, this may be preferable for consistency (even if there is no actual check of the data type).
Co-authored-by: Romain Tartière <[email protected]>
Template does not care:
WSGIDaemonProcess <%= $key %> <%= join(sort($val.map |$k,$v| { "$k=$v"}), ' ') %>
…ppetlabs-apache into wsgi-hash-documentation
|
I updated the documentation to Integers instead of Strings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code says wsgi_daemon_process_options is depreciated
Has been since 0d5e0be
The documentation for that was reverted with 98cf15c