FreeBSD also uses HAProxy 2.1+ these days, adjust defaults

[rvstaveren]

Summary

HAProxy 2.1+ is available as a package for FreeBSD these days, the current defaults let puppet fail due to the deprecated keywords still being used for its default parameter section

[NOTICE]   (60025) : path to executable is /usr/local/sbin/haproxy                                                                 
[ALERT]    (60025) : config : parsing [/usr/local/etc/haproxy.conf20240202-56979-1htrd47:16] : the 'clitimeout' directive is not su
pported anymore since HAProxy 2.1. Use 'timeout client'.                                                                           
[ALERT]    (60025) : config : parsing [/usr/local/etc/haproxy.conf20240202-56979-1htrd47:17] : the 'contimeout' directive is not su
pported anymore since HAProxy 2.1. Use 'timeout connect'.                                                                          
[ALERT]    (60025) : config : parsing [/usr/local/etc/haproxy.conf20240202-56979-1htrd47:24] : keyword 'redispatch' directive is no
t supported anymore since HAProxy 2.1. Use 'option redispatch'.                                                                    
[ALERT]    (60025) : config : parsing [/usr/local/etc/haproxy.conf20240202-56979-1htrd47:26] : the 'srvtimeout' directive is not su
pported anymore since HAProxy 2.1. Use 'timeout server'.                                                                           

Additional Context

Add any additional context about the problem here.

• How to reproduce: Use a supported release of FreeBSD with the HAProxy package

Related Issues (if any)

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.
• [x ] Manually verified. (For example puppet apply)

[CLAassistant]

All committers have signed the CLA.

[rvstaveren]

For what it is worth, I did a manual run of pdk unit test

pdk (INFO): Using Ruby 3.1.4
pdk (INFO): Using Puppet 8.4.0                                   
[✔] Installing missing Gemfile dependencies.
[✔] Preparing to run the unit tests.
/usr/local/bin/ruby31 -I/usr/local/lib/ruby/gems/3.1/gems/rspec-core-3.12.2/lib:/usr/local/lib/ruby/gems/3.1/gems/rspec-support-3.1
2.1/lib /usr/local/lib/ruby/gems/3.1/gems/rspec-core-3.12.2/exe/rspec --pattern spec/\{aliases,classes,defines,functions,hosts,inte
gration,plans,tasks,type_aliases,types,unit\}/\*\*/\*_spec.rb --format progress
Run options: exclude {:bolt=>true}
...................................................................................................................................
...................................................................................................................................
...................................................................................................................................
......................................................................................    
Coverage Report:                                                                                                         [11/94422]
                                                                                                                                   
Total resources:   70                                            
Touched resources: 49                                            
Resource coverage: 70.00%                                        

Untouched resources:       
  Class[Haproxy::Globals]
  Class[Haproxy::Params]                                         
  Concat[/etc/non-default.cfg]
  Concat[/usr/local/etc/haproxy-group1/haproxy-group1.conf]
  Exec[systemctl daemon-reload]                                  
  File[/etc/haproxy-group1]
  File[/etc/sysconfig/haproxy]
  File[/lib/systemd/system/haproxy-group1.service]
  File[/lib/systemd/system/haproxy-haproxy.service]
  Haproxy::Balancermember::Collect_exported[apache]
  Haproxy::Balancermember::Collect_exported[bar]
  Haproxy::Balancermember::Collect_exported[baz]
  Haproxy::Balancermember::Collect_exported[croy]
  Haproxy::Config[group1]
  Haproxy::Config[haproxy]
  Haproxy::Install[group1]
  Haproxy::Install[haproxy]
  Haproxy::Mailer::Collect_exported[bar]
  Haproxy::Peer::Collect_exported[bar]
  Haproxy::Service[group1]
  Haproxy::Service[haproxy]


Deprecation Warnings:

Using `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:ex
pect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /home
/ruben/git/puppetlabs-haproxy/spec/classes/haproxy_spec.rb:30:in `block (5 levels) in <top (required)>'.

If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

1 deprecation warning total

Finished in 21.58 seconds (files took 0.91412 seconds to load)
479 examples, 0 failures