(PDK-1143) changes to work with composite namevars from simple provider #65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 36 36
Lines 848 831 -17
=====================================
- Hits 848 831 -17
Continue to review full report at Codecov.
|
| name: 'foo', | ||
| name: { | ||
| route: 'foo/bar', | ||
| }, |
There was a problem hiding this comment.
the real should would not have the name: hash like this. Is this an artifact of above test data changes with the name hash inline?
Also, I do not understand why there is only one attribute in the name hash here...
| @@ -222,11 +232,19 @@ | |||
| base_xpath: '/some_xpath', | |||
| } | |||
| end | |||
| let(:name) do | |||
| { | |||
| name: { | |||
| @@ -49,6 +49,9 @@ | |||
| interval: '5', | |||
| count: '4', | |||
| enable: true, | |||
| name: { | |||
| path: 'path monitor', | |||
| }, | |||
There was a problem hiding this comment.
would this be easier if name: were a key one level up? Then the shared examples could deal with passing through this, or the plain name? See also below for follow-up problems this causes
|
This is not a full review, and I get the feeling that overall this is working. The additional testing complexity is making it hard for me to review. |
Thomas-Franklin
force-pushed
the
pdk-1143
branch
2 times, most recently
from
ddf1088
to
f56c5d6
Compare
PDK-1143 allows the resource_api to work nicely with composite providers, this PR is a refactor of the `path_monitor` and `static_routes` which work with composite namevars.
Thomas-Franklin
force-pushed
the
pdk-1143
branch
from
f56c5d6
to
a17cabc
Compare
DavidS
changed the title
DavidS
changed the title
|
puppet 6.0.1 has been released with the necessary changes |
PDK-1143 allows the resource_api to work nicely with composite providers, this PR is a refactor of the
path_monitorandstatic_routeswhich work with composite namevars.