Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1603) - Revert back to puppet-lint and rspec-puppet #417

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

jordanbreen28
Copy link
Contributor

this PR reverts the changes used to pinpoint to the newly proposed puppetlabs gems.
These gems are no longer being published.

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@bastelfreak
Copy link
Collaborator

This isn't a git revert of the original commit, right? Would that be an option?

@jordanbreen28
Copy link
Contributor Author

This isn't a git revert of the original commit, right? Would that be an option?

thanks @bastelfreak
have opted to revert the original commits instead

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 526f51a into main Nov 22, 2023
6 checks passed
@LukasAud LukasAud deleted the CAT-1603-revert_dependencies branch November 22, 2023 14:35
@jordanbreen28 jordanbreen28 changed the title (CAT-1603) - Revert dependencies (CAT-1603) - Revert back to puppet-lint and rspec-puppet Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants