Skip non-existing paths in $MODULEPATH silently #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `map`, a `next` will leave a `nil` value in the array. This is a problem since `FileTest.directory? nil` raises "TypeError: no implicit conversion of nil into String" Bug was introduced in v4.0.1, in commit b6bfd6f
kjetilho
force-pushed
the
modulepath_regression
branch
from
b0e420c
to
c3c8171
Compare
bastelfreak
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If one or more components in
$MODULEPATHdo not exist as directories, loading tests will fail with an exception.Additional Context
In
map, anextwill leave anilvalue in the array. This is a problem sinceFileTest.directory? nilraises "TypeError: no implicit conversion of nil into String"I have not seen any difference in behaviour for
FileTest.directory?ornextin.mapfrom Ruby 2.3 to 3.2.Related Issues (if any)
Bug was introduced in v4.0.1, in commit b6bfd6f
For whatever reason, I have stuck to 2.15 for all this time, and that version handles missing directories without complaints. In my case I include "modules" as one of the elements in the path, but not all test environments has/need that directory. It does not seem useful that users have to filter MODULEPATH on their own before launching rspec.
Checklist