Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - "(CAT-1618) - run code coverage on main" #425

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

jordanbreen28
Copy link
Contributor

"(CAT-1618) - run code coverage on main"
pdk version: 3.0.0

@codecov-commenter
Copy link

Codecov Report

Attention: 195 lines in your changes are missing coverage. Please review.

Comparison is base (cbad6f4) 43.28% compared to head (e926adc) 41.90%.
Report is 209 commits behind head on main.

Files Patch % Lines
lib/puppetlabs_spec_helper/tasks/fixtures.rb 38.97% 119 Missing ⚠️
lib/puppetlabs_spec_helper/rake_tasks.rb 27.65% 34 Missing ⚠️
...ib/puppetlabs_spec_helper/puppetlabs_spec/files.rb 33.33% 18 Missing ⚠️
...puppetlabs_spec_helper/puppetlabs_spec/fixtures.rb 33.33% 14 Missing ⚠️
lib/puppetlabs_spec_helper/module_spec_helper.rb 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   43.28%   41.90%   -1.38%     
==========================================
  Files          11       10       -1     
  Lines         841      673     -168     
==========================================
- Hits          364      282      -82     
+ Misses        477      391      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 4e9eff6 into main Jan 19, 2024
8 checks passed
@LukasAud LukasAud deleted the pdksync_cat-1618-run_codecov_main branch January 19, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants