-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parallel_spec_standalone: use --format progress #446
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 41.88% 41.82% -0.07%
==========================================
Files 10 10
Lines 678 679 +1
==========================================
Hits 284 284
- Misses 394 395 +1 ☔ View full report in Codecov by Sentry. |
71888ac
to
7b61bf2
Compare
9242b7a
to
d8f1389
Compare
For the past decade, people used a .rspec_parallel to configure this. We can set it directly in the rake task. That enables us to remove the .rspec_parallel and ultimately reduces the number of files required for pdk update/modulesync.
@bastelfreak 👋 dropping a note to say we aren't ignoring this. I'll update the thread again shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to us! Thanks.
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore.
usually we've a .rspec file in every module: https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot/.rspec.erb By moving this to the rake task we can delete the whole .rspec file. Similar to puppetlabs#446
usually we've a .rspec file in every module: https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot/.rspec.erb By moving this to the rake task we can delete the whole .rspec file. Similar to puppetlabs#446
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
For the past decade, people used a .rspec_parallel to configure this. We can set it directly in the rake task. That enables us to remove the .rspec_parallel and ultimately reduces the number of files required for pdk update/modulesync.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist