Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docker build by forcing older version of public_suffix #2670

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

gmenuel
Copy link
Contributor

@gmenuel gmenuel commented Oct 4, 2022

Currently docker build fail with the following error:

#12 41.61 	The last version of public_suffix (< 6.0, >= 2.0.2) to support your Ruby & RubyGems was 4.0.7. Try installing it with `gem install public_suffix -v 4.0.7` and then running the current command again

This PR fix this by forcing the public_suffix ruby gem to 4.0.7

@gmenuel gmenuel requested a review from a team as a code owner October 4, 2022 12:59
@mwaggett
Copy link
Contributor

Hi @gmenuel, thanks for opening this!

Unfortunately, it has been decided that we will no longer be maintaining docker images for Puppet's projects. If you have tested this change and are satisfied that it solves your problem, I am happy to merge this pull request, but please be aware that we at Puppet will not be doing any additional testing of this change and we will not be fixing any bugs that may arise as a result of this, or any other changes.

If you would still like me to merge this, let me know! Otherwise, this PR will be closed in a few weeks.

@gmenuel
Copy link
Contributor Author

gmenuel commented Oct 17, 2022

Ok I understand, Docker image are needed for my company for running puppetserver in kube, but if the image is not maintained anymore I will look into building the image on our side. Still I've checked that this PR fix the build issue and the built image is working properly so I think that merging it could be useful (for me and others).

For information I've opened a similar PR on puppetdb : puppetlabs/puppetdb#3723

@mwaggett
Copy link
Contributor

Sounds good, thanks @gmenuel !

@mwaggett mwaggett merged commit da775d5 into puppetlabs:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants