(maint) Improve PCP broker and client usage in acceptance #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2016 11:19
…nning with --debug [skip ci]
…er method 010_Setup_Broker.rb and test_helper.rb contained duplicate code for running pcp-broker in trapperkeeper. This commit changes 010_Setup_Broker.rb to use test_helper.rb's run_pcp_broker method [skip ci]
| @@ -6,6 +6,9 @@ | |||
|
|
|||
| # This file contains general test helper methods for pxp-agent acceptance tests | |||
|
|
|||
| # The standard path for git checkouts is where pcp-broker will be | |||
| GIT_CLONE_FOLDER = '/opt/puppet-git-repos' | |||
There was a problem hiding this comment.
I'm not happy with this being defined here. I've created PCP-298 to refactor this lib - possibly at this point pcp-broker deserves its own helper file
There was a problem hiding this comment.
The comment says it's standard, so doesn't the place where it's standardised export a constant?
There was a problem hiding this comment.
On checking out the branch and poking around I now follow - this is the standard place, as it's now common to the call to clone_git_repo_on in acceptance/setup/common/010_Setup_Broker.rb and the run_pcp_broker helper here. Will do for now.
richardc
added a commit
that referenced
this pull request
Feb 12, 2016
(maint) Improve PCP broker and client usage in acceptance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of minor improvements: