Make use of ruby-pcp-client 0.2.0 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we bump the dependency on pcp-client gem to 0.2.0 so we can some of the fixes that should make connection errors more diagnosable.
We can tell quite an amount about why the client failed to connect if we inspect it and look at its instance variables and the instance variables of the wrapped websockets connection object.
By using PCP::SimpleLogger the later .inspect of the failed
client state will include the logged lines about why it failed to
connect, something like:
<PCP::Client:0x007fc8b52defd0
@logger=#<PCP::SimpleLogger:0x007fc8b52df0e8
@events=[
{:when=>1455722334.0191228, :severity=>0, :message=>[:connect, "wss://localhost:8142/pcp"]},
{:when=>1455722334.019747, :severity=>1, :message=>[:close, 1006, ""]}], @Level=0>
...>
richardc
changed the title
james-stocks
pushed a commit
that referenced
this pull request
Feb 18, 2016
Make use of ruby-pcp-client 0.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the (not yet released) 0.2.0 feature of
PCP::SimpleLoggerso we can inspect the state of the client object should it not be connected and give more context as to why the connection failed.