-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) Allow use of beaker 3.x in acceptance tests #546
(maint) Allow use of beaker 3.x in acceptance tests #546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CLA signed by all contributors. |
If you want this everywhere, you should target it at LTS-1.7. Where does it apply? |
Marking this do not merge until some unexpected issues with beaker are sorted out. |
@MikaelSmith btw, this is needed for Ubuntu 16.10 support, which is targeted for release in 1.9.0. Not sure if we want it everywhere atm. |
Ok, then master seems sufficient. |
Ok, the beaker-facter gem has been updated to resolve the issues we were seeing. This PR is now safe to merge. |
This PR is blocked again until puppetlabs/facter#1495 is addressed. |
This updates the Gemspec to allow the use of beaker 3.x, which is needed to include support for new platforms (Ubuntu 16.10 in particular).
7a0aa22
to
5791c5f
Compare
I've rebased this PR and targeted it at stable for inclusion in puppet-agent 1.9.1. |
This updates the Gemspec to allow the use of beaker 3.x, which
is needed to include support for new platforms (Ubuntu 16.10
in particular).