Handle nil autorequire results #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering results containing nil from an autorequire-family call, Puppet will skip over them without error but rspec-puppet results in an error. This aligns rspec-puppet with Puppet's behavior. Also, rename the autorelationships spec test so that it runs properly as part of a 'rake spec' invocation.
ekohl
approved these changes
Jan 11, 2022
Use notify, an OS-neutral resource type, instead of File for the testing.
I just pushed an update I expect will fix the test failures on Windows. Thanks! |
ekohl
approved these changes
Jan 12, 2022
michaeltlombardi
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encountering results containing nil from an autorequire-family
call, Puppet will skip over them without error but rspec-puppet
results in an error. This aligns rspec-puppet with Puppet's
behavior.
Also, rename the autorelationships spec test so that it runs
properly as part of a 'rake spec' invocation.