Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MAINT) Run PDK update #313

Merged
merged 1 commit into from
May 15, 2024
Merged

(MAINT) Run PDK update #313

merged 1 commit into from
May 15, 2024

Conversation

LukasAud
Copy link
Contributor

This commit runs the PDK update command to bring the Gemfile and other configuration up to date with current standards.

@LukasAud LukasAud requested a review from a team as a code owner May 15, 2024 08:09
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (48f1df4) to head (e068e37).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files           6        6           
  Lines         714      714           
=======================================
  Hits          657      657           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28
Copy link
Contributor

We should probably back out all the rubocop changes here, as the way rubocop configured before is the preferred way, and we are scheduling removing the extra cops from the templates. @LukasAud what you think?

@jordanbreen28 jordanbreen28 merged commit ac4981b into main May 15, 2024
8 checks passed
@jordanbreen28 jordanbreen28 deleted the MAINT-PDK_update branch May 15, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants