(CAT-1869) - Add configurable dsc_timeout #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
cat-1869-add_configurable_timeout
branch
3 times, most recently
from
d1c7df4
to
9a4a837
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 92.01% 92.10% +0.08%
==========================================
Files 6 6
Lines 714 722 +8
==========================================
+ Hits 657 665 +8
Misses 57 57 ☔ View full report in Codecov by Sentry. |
jordanbreen28
force-pushed
the
cat-1869-add_configurable_timeout
branch
from
bc2c5f6
to
dd76db3
Compare
This commit introduces a new instance variable @timeout, set to nil by default. A new method set_dsc_timeout is added to handle the setting of @timeout based on the name_hash[:dsc_timeout] value. This timeout specifies the number of seconds the ps_manager will await the dsc invocation to return, before moving on. The ps_manager.execute method call now includes the timeout value. The error message for when output is nil has been updated to include information about the timeout, if it is set. Does not affect previous behaviour, therefore is completely backwards compatible with previous versions.
jordanbreen28
force-pushed
the
cat-1869-add_configurable_timeout
branch
2 times, most recently
from
8a31945
to
26cb1e1
Compare
jordanbreen28
force-pushed
the
cat-1869-add_configurable_timeout
branch
from
26cb1e1
to
f7094c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new instance variable @timeout, set
to nil by default. A new method set_dsc_timeout is added to
handle the setting of @timeout based on the name_hash[:dsc_timeout]
value. This timeout specifies the number of seconds the ps_manager will
await the dsc invocation to return, before moving on.
The ps_manager.execute method call now includes the timeout value.
The error message for when output is nil has been updated to include
information about the timeout, if it is set.
Does not affect previous behaviour, therefore is completely backwards
compatible with previous versions.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist