Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make css and className optional for element and elementKeyed #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvliwanag
Copy link

Fixes #18

I can also update the example if need be to remove className and demonstrate it can be used without.

@i-am-the-slime
Copy link
Member

@mjrussell Any chance of this making it in?

@mjrussell
Copy link
Member

Yeah it looks like a good improvement. @jvliwanag do you want to fix the conflicts?

@mjrussell
Copy link
Member

Updating the example for with and without would be super helpful but could be done later

@i-am-the-slime
Copy link
Member

@mjrussell I don't think @jvliwanag really does PS anymore, so we might have to take this over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept props without css or className
3 participants