Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM 19 aarch64 now supports preserve_none #33

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

calebh
Copy link
Contributor

@calebh calebh commented Jul 29, 2024

aarch64 support for the preserve_none attribute has landed in LLVM 19. Note that the preserve_none support for aarch64 seems to be under active development. The order of the registers in the calling convention has changed at least once, and seems to be subject to change. The up to date calling convention can be found in the LLVM repository here:

https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AArch64/AArch64CallingConvention.td#L529C34-L533C51

Unfortunately I am not able to test out the new LLVM 19 support for aarch64. The laptop that I was previously using for testing Patcherex2 is at home in my apartment, and I am traveling until August 11.

I am not sure if the LLVM 19 apt trunk distributions have the latest calling convention yet. We may want to wait a couple more weeks to see if things stabilize before merging this pull request.

Funding for AMP at Draper ends at the end of July, so I will have limited resources if something drastic needs to change in August.

@DennyDai
Copy link
Collaborator

Thanks for the info! I'll take care of this later this week (if the update has reached apt by then). Safe travels!

@DennyDai DennyDai merged commit 84d6271 into purseclab:main Aug 3, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants