Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_high_availability_settings #102

Merged

Conversation

LuminatiHD
Copy link
Contributor

No description provided.

@LuminatiHD LuminatiHD force-pushed the feature/system_high_availability_settings branch from 73779ae to a829773 Compare April 24, 2024 12:15
@LuminatiHD LuminatiHD force-pushed the feature/system_high_availability_settings branch from de7e81e to 0e4c8d1 Compare May 23, 2024 14:11
@LuminatiHD LuminatiHD force-pushed the feature/system_high_availability_settings branch 3 times, most recently from 6109c4d to f6843b4 Compare May 24, 2024 13:51
@LuminatiHD LuminatiHD force-pushed the feature/system_high_availability_settings branch from f6843b4 to 61c65b1 Compare May 24, 2024 13:54
@LuminatiHD LuminatiHD marked this pull request as ready for review May 24, 2024 13:57
@LuminatiHD LuminatiHD linked an issue May 29, 2024 that may be closed by this pull request
@LuminatiHD LuminatiHD force-pushed the feature/system_high_availability_settings branch from efdf2a0 to d3f20d2 Compare May 29, 2024 13:14
@cfasnacht cfasnacht self-requested a review June 12, 2024 10:48
@LuminatiHD LuminatiHD merged commit 08d1def into puzzle:main Jun 19, 2024
30 checks passed
KiLLuuuhh pushed a commit to KiLLuuuhh/puzzle.opnsense that referenced this pull request Jun 27, 2024
* very basic scaffolding

* Add support for settings with None values

* add tests + bugfix

* revert changes on module_index

* some Linting

* interact directly w/ config

* add tests services (i forgot)

* Apply suggestions from code review

Co-authored-by: Fabio Bertagna <[email protected]>

* validate interfaces before assigning

* revision (separate tests)

* make the linter not cry

* make the linter not cry

* bugfixes + linting + some better docs

* validate interfaces before assignment + converge

* fix tests + some linting

* remove files i forgot to delete

* lint + sanity tests

* better testsbetter tests

* sanity + return var

* validate param synchronize_peer_ip

* clear username, password and remote_backup_url when empty

* add typing

* add params disable_preempt, disconnect_dialup_interfaces

* remove unnecessary change

* add comments for services_to_synchronize

* add version specific tests

---------

Co-authored-by: Fabio Bertagna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module Request: system_high_availability_settings
3 participants