Draft: Add config object base class #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonGiovanni83
changed the base branch from
main
to
feature/config_objects_remodeling
* Fix logging settings module 24.7 support * Add changelog fragment for 153 * Lint system logging module * Fix molecule tests for 24.7 logging
* Set galaxy version * Generate changelog
|
Further work will be done in my frok and a new PR will follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These Changes adds a basic ConfigObject class which should enable inheritance for config objects (eg. FirewallRule, Groups. User, etc...) . This approach should save us a lot of boiler plate code across different config objects.