Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: dhcpv4 Module #84

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Draft: dhcpv4 Module #84

wants to merge 10 commits into from

Conversation

ombre8
Copy link
Member

@ombre8 ombre8 commented Mar 23, 2024

Added a dhcpv4 Module, desperately looking for feedback since I honestly didn't understand everything I did 😸

ToDo:

  • get interface from module to config Map, aka we need a way to get module_args to xml paths (do we have that yet? or do we need to implement that?)
  • input validation
  • add more test?

closes #58

@KiLLuuuhh
Copy link
Contributor

I would suggest renaming the file plugins/module_utils/services_dhcpv4.py to plugins/module_utils/services_dhcpv4_utils.py to be consistent with the other utils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module Request: services_dhcpv4
2 participants