Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov CI configuration to fix PR coverage uploads #2022

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Apr 29, 2024

  • Closes Codecov CI error uploading report #2008
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Codecov has made some updates regarding uploading coverage from forks of public repositories. See codecov/feedback#301 (comment)

This PR is to see if it works for us. It may take some iteration, so marking as draft/WIP for now.

@kandersolar kandersolar added the build tools Pipelines, CI, GH actions label Apr 29, 2024
@kandersolar kandersolar added this to the v0.10.5 milestone Apr 29, 2024
@kandersolar kandersolar marked this pull request as ready for review April 29, 2024 18:00
@kandersolar kandersolar changed the title [WIP] Update codecov CI configuration to fix PR coverage uploads Update codecov CI configuration to fix PR coverage uploads Apr 29, 2024
@kandersolar
Copy link
Member Author

It seems to have worked for this PR: https://app.codecov.io/gh/pvlib/pvlib-python/commit/a77ca9c63995e11967fb39fd93372d92a46e1bfe

As mentioned in #2008 (comment), I will merge this and check whether the problem is also resolved on main.

@kandersolar kandersolar merged commit a49d143 into pvlib:main Apr 29, 2024
33 of 35 checks passed
@kandersolar kandersolar deleted the codecov-upload-fix branch April 29, 2024 18:03
@kandersolar kandersolar mentioned this pull request Apr 29, 2024
8 tasks
echedey-ls pushed a commit to echedey-ls/pvlib-python that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build tools Pipelines, CI, GH actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov CI error uploading report
1 participant