Agrivoltaics - PAR diffuse fraction model #2048

echedey-ls · 2024-05-12T00:16:30Z

Closes Photosynthetically active radiation decomposition model #2047
I am familiar with the contributing guidelines
Tests added
Updates entries in docs/sphinx/source/reference for API changes.
Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
Pull request is nearly complete and ready for detailed review.
Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Adds the model described in #2047.

Current implementation

I'm a bit hesitant about the tests here. I haven't found any straightforward way to make the tests from the papers. They check the mathematical integrity of the implementation, if that's a thing.

Docs links

AdamRJensen

Just an early stage review.

docs/examples/agrivoltaics/plot_diffuse_PAR_Spitters_relationship.py

pvlib/par.py

pvlib/tests/test_par.py

Co-authored-by: Adam R. Jensen <[email protected]>

echedey-ls · 2024-05-30T17:23:42Z

Moved to irradiance.py!! (I'm a request away to do a poll via reaction emojis 😅 😉 )

Everybody, feel free to review 👀 .

docs/sphinx/source/reference/irradiance/components.rst

pvlib/irradiance.py

Co-Authored-By: Kevin Anderson <[email protected]>

Co-authored-by: Cliff Hansen <[email protected]>

…om/echedey-ls/pvlib-python into par-diffuse-fraction-of-global-par

Co-Authored-By: Cliff Hansen <[email protected]>

Instead of `spitters_relationship` Co-Authored-By: Cliff Hansen <[email protected]>

Co-Authored-By: Cliff Hansen <[email protected]>

echedey-ls · 2024-06-18T23:28:29Z

Again, thx for the review

AdamRJensen

The reference mentions

where the subscript d points to daily totals

Is it correct that the expression is for daily values? If so, that needs to be denoted in the ocstring.

pvlib/irradiance.py

AdamRJensen

Great job! Just a few minor comments

docs/examples/agrivoltaics/plot_diffuse_PAR_Spitters_relationship.py

AdamRJensen · 2024-06-19T07:13:11Z

docs/examples/agrivoltaics/plot_diffuse_PAR_Spitters_relationship.py

+# calculated using the Spitter's relationship [1]_ implemented in
+# :py:func:`~pvlib.irradiance.diffuse_par_spitters`.
+# This model requires the solar zenith angle and the fraction of the broadband
+# radiation that is diffuse as inputs.


Suggested change

# radiation that is diffuse as inputs.

# irradiance that is diffuse as inputs.

To (perhaps) head off a discussion of whether "radiation" or "irradiance" should be used here: radiation is usually used when referring to the source, and irradiance (or irradiation) when referring to the receiver. So the sun emits radiation, and a tilted plane on the earth's surface receives solar irradiation. Either perspective seems OK to me in the context of this PR. But mixing PAR (..."radiation") with "irradiance" may be confusing to some.

docs/examples/agrivoltaics/plot_diffuse_PAR_Spitters_relationship.py

AdamRJensen · 2024-06-19T07:17:37Z

docs/examples/agrivoltaics/plot_diffuse_PAR_Spitters_relationship.py

+# The total PAR can be approximated as 0.50 times the broadband horizontal
+# irradiance (GHI) for solar elevation higher that 10°.


Is PAR simply 0 at solar elevation angles less than 10 degrees? Seems odd

Co-Authored-By: Adam R. Jensen <[email protected]>

echedey-ls · 2024-06-19T08:42:13Z

Is it correct that the expression is for daily values? If so, that needs to be denoted in the docstring.

@AdamRJensen you are completely right. I remember reading that but not in the original paper, so I thought the integration was done later. I didn't read the solar elevation was averaged neither :(

I will update the docs and the example. Should I call the irradiance integral radiation or insolation? The paper uses the former, but I've seen the latter in pvpmc.sandia.gov

Btw, I don't know which day the release will be done, so feel free to exclude this PR from the merge list.

Co-Authored-By: Adam R. Jensen <[email protected]>

cwhanse · 2024-06-19T14:19:40Z

Is it correct that the expression is for daily values? If so, that needs to be denoted in the docstring.

I missed that as well. If the relationship is only for daily values, that fact should be stated prominently.

AdamRJensen · 2024-06-19T14:36:34Z

Is it correct that the expression is for daily values? If so, that needs to be denoted in the docstring.

I missed that as well. If the relationship is only for daily values, that fact should be stated prominently.

Upon skimming it briefly it seems to be daily values. @echedey-ls do you know what units they use, e.g., W/m2 vs Wh/m2?

The corrections happening in the equation account for differences in overcast vs clear sky days, which makes me doubt that's its for daily values (though it could just be accounting for whether the day is mostly cloudy or clear). But then why is PAR less than 10 degrees set to 0? Is that if the daily average solar elevation is less than 10? I think this probably deserves a more careful read

echedey-ls · 2024-06-19T21:09:21Z

Upon skimming it briefly it seems to be daily values. @echedey-ls do you know what units they use, e.g., W/m2 vs Wh/m2?

From page 11

But then why is PAR less than 10 degrees set to 0? Is that if the daily average solar elevation is less than 10?

I think you are right. I set it to zero because nothing came up to my head about how to handle and interpret that statement in the paper. I did that thinking the solar elevation was an instantaneous value, not the average. In the upcoming example I will fix that. And possibly include a warning in the function too.

Co-Authored-By: Adam R. Jensen <[email protected]>

AdamRJensen · 2024-06-20T15:31:33Z

@cwhanse I'm happy with the state of this PR. If you also approve, I think this could be merged in time for the 0.11.0 release.

cwhanse

One more small edit and LGTM also

pvlib/irradiance.py

Co-authored-by: Cliff Hansen <[email protected]>

AdamRJensen · 2024-06-20T15:53:39Z

Thank you @echedey-ls!

Great work and go GSoC 🥳

echedey-ls added 7 commits May 3, 2024 03:27

New PAR module with spitters_relationship

90dd1e0

Merge branch 'main' into par-diffuse-fraction-of-global-par

8cc7ffc

Update v0.11.0.rst

ae63127

linter

5880453

API update

5af860a

Example rendering

bdc2303

Update test_par.py

aec7870

kandersolar added this to the 0.11.0 milestone May 17, 2024

kandersolar added the enhancement label May 17, 2024

echedey-ls mentioned this pull request May 23, 2024

GSoC participation roadmap of Echedey #2064

Closed

AdamRJensen reviewed May 24, 2024

View reviewed changes

Apply suggestions from code review (Adam)

02ebe81

Co-authored-by: Adam R. Jensen <[email protected]>

AdamRJensen added the GSoC Contributions related to Google Summer of Code. label May 24, 2024

echedey-ls added 3 commits May 24, 2024 13:11

Update par.py

c5d133d

Move function to spectrum (mismatch.py)

149961e

Improve units formatting

eff3a25

echedey-ls marked this pull request as ready for review May 24, 2024 11:36

echedey-ls added 4 commits May 24, 2024 13:45

Split legends

d18827e

Remove api page, move to spectrum index

18619a4

Update v0.11.0.rst

feded95

Merge branch 'main' into par-diffuse-fraction-of-global-par

b9aa23e

cwhanse mentioned this pull request May 25, 2024

Photosynthetically active radiation decomposition model #2047

Closed

echedey-ls added 2 commits May 30, 2024 19:13

Move to irradiance.py

1c6d416

Flake8 🔪

899844c

kandersolar reviewed Jun 14, 2024

View reviewed changes

docs/sphinx/source/reference/irradiance/components.rst Outdated Show resolved Hide resolved

pvlib/irradiance.py Outdated Show resolved Hide resolved

echedey-ls and others added 4 commits June 14, 2024 21:45

Fix trigonometry - double testing with a spreadsheet

9268a44

Co-Authored-By: Kevin Anderson <[email protected]>

Move section of PAR

bce50b6

Co-Authored-By: Kevin Anderson <[email protected]>

Merge branch 'main' into par-diffuse-fraction-of-global-par

2825e2c

I should read more carefully

764bf8b

Co-Authored-By: Kevin Anderson <[email protected]>

echedey-ls and others added 6 commits June 19, 2024 01:03

Apply suggestions from code review (Cliff)

0d23fe0

Co-authored-by: Cliff Hansen <[email protected]>

Merge branch 'par-diffuse-fraction-of-global-par' of https://github.c…

a7c84b5

…om/echedey-ls/pvlib-python into par-diffuse-fraction-of-global-par

More docs refurbishment

d1bb64b

Co-Authored-By: Cliff Hansen <[email protected]>

Rename to diffuse_par_spitters

eeef154

Instead of `spitters_relationship` Co-Authored-By: Cliff Hansen <[email protected]>

global -> broadband

6082fe7

Co-Authored-By: Cliff Hansen <[email protected]>

Merge branch 'main' into par-diffuse-fraction-of-global-par

94df738

echedey-ls requested a review from AdamRJensen June 18, 2024 23:28

AdamRJensen reviewed Jun 19, 2024

View reviewed changes

pvlib/irradiance.py Outdated Show resolved Hide resolved

pvlib/irradiance.py Outdated Show resolved Hide resolved

pvlib/irradiance.py Outdated Show resolved Hide resolved

pvlib/irradiance.py Outdated Show resolved Hide resolved

AdamRJensen approved these changes Jun 19, 2024

View reviewed changes

echedey-ls marked this pull request as draft June 19, 2024 08:01

echedey-ls and others added 5 commits June 19, 2024 10:03

Code review from Adam, first batch

ac9d45c

Co-Authored-By: Adam R. Jensen <[email protected]>

Apply trigonometric property

77f3ba8

Merge branch 'main' into par-diffuse-fraction-of-global-par

a6c3c6b

Fix merge - linter

f5449d7

Forgot to apply this comment

bafe63b

Co-Authored-By: Adam R. Jensen <[email protected]>

Remove model from eq

1a5d0d9

Co-Authored-By: Adam R. Jensen <[email protected]>

Dailies, insolation instead of instant, irradiance values

189efe5

Co-Authored-By: Adam R. Jensen <[email protected]>

echedey-ls marked this pull request as ready for review June 20, 2024 12:56

More docs refurbishment

7c28be6

Co-Authored-By: Adam R. Jensen <[email protected]>

cwhanse approved these changes Jun 20, 2024

View reviewed changes

pvlib/irradiance.py Outdated Show resolved Hide resolved

Review from Cliff

59faee0

Co-authored-by: Cliff Hansen <[email protected]>

AdamRJensen merged commit 229a187 into pvlib:main Jun 20, 2024
30 checks passed

echedey-ls deleted the par-diffuse-fraction-of-global-par branch June 20, 2024 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agrivoltaics - PAR diffuse fraction model #2048

Agrivoltaics - PAR diffuse fraction model #2048

echedey-ls commented May 12, 2024 •

edited

Loading

AdamRJensen left a comment

echedey-ls commented May 30, 2024

echedey-ls commented Jun 18, 2024

AdamRJensen left a comment

AdamRJensen left a comment

AdamRJensen Jun 19, 2024

cwhanse Jun 19, 2024

AdamRJensen Jun 19, 2024

echedey-ls commented Jun 19, 2024

cwhanse commented Jun 19, 2024

AdamRJensen commented Jun 19, 2024 •

edited

Loading

echedey-ls commented Jun 19, 2024

AdamRJensen commented Jun 20, 2024

cwhanse left a comment

AdamRJensen commented Jun 20, 2024

	# radiation that is diffuse as inputs.
	# irradiance that is diffuse as inputs.

		# The total PAR can be approximated as 0.50 times the broadband horizontal
		# irradiance (GHI) for solar elevation higher that 10°.

Agrivoltaics - PAR diffuse fraction model #2048

Agrivoltaics - PAR diffuse fraction model #2048

Conversation

echedey-ls commented May 12, 2024 • edited Loading

Current implementation

Docs links

AdamRJensen left a comment

Choose a reason for hiding this comment

echedey-ls commented May 30, 2024

echedey-ls commented Jun 18, 2024

AdamRJensen left a comment

Choose a reason for hiding this comment

AdamRJensen left a comment

Choose a reason for hiding this comment

AdamRJensen Jun 19, 2024

Choose a reason for hiding this comment

cwhanse Jun 19, 2024

Choose a reason for hiding this comment

AdamRJensen Jun 19, 2024

Choose a reason for hiding this comment

echedey-ls commented Jun 19, 2024

cwhanse commented Jun 19, 2024

AdamRJensen commented Jun 19, 2024 • edited Loading

echedey-ls commented Jun 19, 2024

AdamRJensen commented Jun 20, 2024

cwhanse left a comment

Choose a reason for hiding this comment

AdamRJensen commented Jun 20, 2024

echedey-ls commented May 12, 2024 •

edited

Loading

AdamRJensen commented Jun 19, 2024 •

edited

Loading