-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move albedo dictionary from pvlib.irradiance
to pvlib.albedo
#2095
Move albedo dictionary from pvlib.irradiance
to pvlib.albedo
#2095
Conversation
@IoannisSifnaios check out https://peps.python.org/pep-0562/. I wasn't sure it was available in all of our python versions, but looks like 3.7+ allows it, so we can use it in pvlib. It allows basically the same thing (a custom |
@kandersolar for some reason, the function added for the deprecation warning fails some existing tests. Can you take a look at it? |
A semi-informed guess: modifying |
…naios/pvlib-python into deprecate_albedo_dict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach seems good to me. Good job finding all the places the docs mention that dictionary!
pvlib.irradiance
to pvlib.albedo
Thanks @IoannisSifnaios! |
[ ] Closes #xxxx[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Deprecate the
SURFACE_ALBEDOS
dictionary from theirradiance.py
. The dictionary is now moved to thealbedo.py
module.