-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle time normalization for nonexistent and ambiguous times #2133
Open
scttnlsn
wants to merge
12
commits into
pvlib:main
Choose a base branch
from
scttnlsn:normalize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
30bb319
Handle time normalization for nonexistent and ambiguous times
scttnlsn 6000bb2
Test that Pandas normalize raises time errors
scttnlsn 6354443
Fix whitespace
scttnlsn 2348afd
Fix handling of ambiguous times during DST shift
scttnlsn 844a8b0
Raise excption on ambiguous time
scttnlsn 92b1d28
Update pvlib/solarposition.py
scttnlsn 5b79e00
Add scttnlsn to 0.11.1 contributors list
scttnlsn f271274
Merge branch 'main' into normalize
cwhanse 2466e7b
Update pvlib/tests/test_solarposition.py
scttnlsn 4ed2315
Update hour_angle docstring
scttnlsn 104bb23
Update pvlib/solarposition.py
scttnlsn 5f85c32
Merge branch 'main' into normalize
cwhanse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this with the modification of
def hour_angle(times, longitude, equation_of_time)
intodef hour_angle(times, longitude, equation_of_time, nonexistent='shift_forward', ambiguous='raise')
to give users a choice to control thetz_localize
behavior if they want rather than just receiving an error and being blocked?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scttnlsn could you comment on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user would not necessarily be blocked if the exception is raised. They'd just need to convert the given times to a non-DST timezone ahead of calling
hour_angle
. The documentation is updated to mention this.infer
won't really work as mentioned here: #2133 (comment) The other options are toraise
(current approach) or to haveNaN
s returned where the times are ambiguous (the user still likely needs to deal with that case).I'm personally of the opinion that forcing the user to convert to a non-DST timezone is a fine approach but I could understand someone might want to have
NaN
s instead.