-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize v0.11.1 #2225
Finalize v0.11.1 #2225
Conversation
Windows test failures are irrelevant. Perhaps due to mamba-org/mamba#3467 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM!
Just wanna add that, in addition to the nice comments @RDaxini left, I would reformat this entries under "Documentation" to make it more concise:
https://github.com/kandersolar/pvlib-python/blob/82e47829fb5390887f6ad07778a982f9fa14decb/docs/sphinx/source/whatsnew/v0.11.1.rst?plain=1#L63C1-L72C32
Currently:
* Added gallery example demonstrating the application of
several spectral mismatch factor models.
(:issue:`2107`, :pull:`2114`)
* Added gallery example demonstrating the application of
:py:func:`~pvlib.spectrum.average_photon_energy`. (:issue:`2194`, :pull:`2206`)
* Added gallery example on calculating cell temperature for
floating PV. (:pull:`2110`)
* Added gallery example demonstrating how to use
different Perez coefficients in a ModelChain.
(:issue:`2127`, :pull:`2148`)
to something along:
* Added multiple examples to the gallery:
* Demonstrating the application of
several spectral mismatch factor models.
(:issue:`2107`, :pull:`2114`)
* Demonstrating the application of
:py:func:`~pvlib.spectrum.average_photon_energy`. (:issue:`2194`, :pull:`2206`)
* Calculating cell temperature for
floating PV. (:pull:`2110`)
* Demonstrating how to use
different Perez coefficients in a ModelChain.
(:issue:`2127`, :pull:`2148`)
Co-Authored-By: RDaxini <[email protected]> Co-Authored-By: Echedey Luis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but noting one nit: do we prefer that function links show the full path or just the function name? The difference in the whatsnew file is whether the tilde "~" prefaces the function path.
Personally I think it's cleaner to use the "~" and omit the e.g. "pvlib.pvsystem." path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with +1 for using "~" (comment)
(shame there's no way to retain just the module part of the path (iotools, spectrum...) otherwise I might have preferred that...)
For new functions, maybe it is helpful to show the full path? More generally I tend to agree that the path is just clutter. But I'm sure I haven't followed any consistent rule in my own whatsnew entries thus far. I'll go through and add the tildes throughout this file. |
Thanks for the reviews! I'll proceed with making the release. Also, looking through the what's new file, I'm struck by how much of it came from our 2024 GSoC crew -- thanks @IoannisSifnaios, @RDaxini, and @echedey-ls :) |
docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.