Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style guide for references in contributing.rst #2226

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Sep 26, 2024

  • Closes Standard citation style across docs #2202
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini
Copy link
Contributor Author

RDaxini commented Sep 27, 2024

Questions:
Too long?
More (variety of) example reference types? So far there's the general format for a journal paper, and two examples: journal paper and conference paper
Is it okay to link to a pdf? the pdf was found here

@cwhanse
Copy link
Member

cwhanse commented Sep 27, 2024

Questions: Too long?

No, but a bit wordy in places. I can edit if you'd like.

More (variety of) example reference types?

Yes. I think add a book or book chapter, and a technical report from some lab.

Is it okay to link to a pdf?

I don't see why not.

@RDaxini RDaxini marked this pull request as ready for review September 27, 2024 15:23
@RDaxini
Copy link
Contributor Author

RDaxini commented Sep 27, 2024

Questions: Too long?

No, but a bit wordy in places. I can edit if you'd like.

Sure, please go ahead

More (variety of) example reference types?

Yes. I think add a book or book chapter, and a technical report from some lab.

Okay will do

@RDaxini RDaxini changed the title [WIP] Add style guide for references in contributing.rst Add style guide for references in contributing.rst Sep 27, 2024
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
@AdamRJensen
Copy link
Member

AdamRJensen commented Sep 28, 2024

I think we should encourage users not to format it manually, but perhaps use something like this: https://citation.crosscite.org/

Also, the DOI should be required if there is one.

Last, might be a good idea to link to the official IEEE description: https://journals.ieeeauthorcenter.ieee.org/wp-content/uploads/sites/7/IEEE_Reference_Guide.pdf

The official guide (above) states the following, which we should abide by:

IEEE publications must list names of all authors, up to six names. If there are more than six names listed, use the primary author’s name followed by “et al.”

@RDaxini
Copy link
Contributor Author

RDaxini commented Sep 28, 2024

I think we should encourage users not to format it manually, but perhaps use something like this: https://citation.crosscite.org/

Do we want pvlib to endorse one particular citation generator though...? I think most people would be aware of such sites and just go ahead and use one themselves if they want to.

Also, the DOI should be required if there is one.

Already included, see line 85

Last, might be a good idea to link to the official IEEE description: https://journals.ieeeauthorcenter.ieee.org/wp-content/uploads/sites/7/IEEE_Reference_Guide.pdf

Already included, see line 78 in the original, 77 since the last commit

The official guide (above) states the following, which we should abide by:

IEEE publications must list names of all authors, up to six names. If there are more than six names listed, use the primary author’s name followed by “et al.”

Have now added it in (line 81)

@kandersolar kandersolar added this to the v0.11.2 milestone Oct 1, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK with me

docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like so many details aren't necessary. In fact, so many details on how IEEE work may encourage contributors to manually type the citations. But I can live with that.

Do we want pvlib to endorse one particular citation generator though...?

I'd say we don't want to, but citing "Use of a citation generator is recommended" at least somewhere would be nice. Whether or not to provide a link... dunno. I wouldn't put it just as there are plenty of them.

In addition, maybe add Zotero, other bib managers or the published paper webpage as sources to get the IEEE citation from.

LGTM nevertheless, this section would definitely be remembered for whoever reads it!

docs/sphinx/source/contributing/style_guide.rst Outdated Show resolved Hide resolved
@AdamRJensen
Copy link
Member

On a couple of recent PRs to another repo I've been using the IEEE citation format... and I really dislike how the first name initial comes first. It seems that most pvlib functions already are using a somewhat fairly consistent format - anyone know what that is?

@cwhanse
Copy link
Member

cwhanse commented Oct 4, 2024

It seems that most pvlib functions already are using a somewhat fairly consistent format - anyone know what that is?

Likely, just imitating other references. There hasn't been a citation style specified or requested before.

@RDaxini
Copy link
Contributor Author

RDaxini commented Oct 7, 2024

@AdamRJensen I also think the initial/name order is a slightly odd, it's not what I am used to anyway, but it's not a dealbreaker for me. I think IEEE is still a good choice. Is there another style you'd recommend?

@mikofski
Copy link
Member

mikofski commented Oct 7, 2024

I feel like so many details aren't necessary. In fact, so many details on how IEEE work may encourage contributors to manually type the citations. But I can live with that.

Do we want pvlib to endorse one particular citation generator though...?

I'd say we don't want to, but citing "Use of a citation generator is recommended" at least somewhere would be nice. Whether or not to provide a link... dunno. I wouldn't put it just as there are plenty of them.

In addition, maybe add Zotero, other bib managers or the published paper webpage as sources to get the IEEE citation from.

LGTM nevertheless, this section would definitely be remembered for whoever reads it!

What would be cool is a Zotero group or library that we could share with pvlib users

Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be cool is a Zotero group or library that we could share with pvlib users

@mikofski I'm completely ignorant on that feature of Zotero, but the bibtex file with references in pvlib would be super for that? I mean, centralized in the repo so nobody ever forgets about updating it, in the same PRs that get accepted, and for those non-Zotero users a webpage with all the references to find if a paper is or not relevant in pvlib / a model is a good candidate.

@@ -15,6 +15,10 @@ Enhancements
Documentation
~~~~~~~~~~~~~
* Edited docstrings for :py:func:`~pvlib.pvsystem.dc_ohms_from_percent` and
:py:func:`~pvlib.pvsystem.dc_ohmic_loss` for clarity. (:issue:`1601`, :pull:`2229`)
* Added a new reference style guide to the contributing page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added a new reference style guide to the contributing page.
* Added a new bibliographic reference style guide to the contributing page.

Plain reference style guide, reads like a style guide of reference for code style? IDK, it's good as it is.
May as well link to it with :ref:`references` .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added a new reference style guide to the contributing page.
* Added a new reference citation style guide to the contributing page.

I think "citation" is more clear than "bibliographic"

@AdamRJensen
Copy link
Member

@AdamRJensen I also think the initial/name order is a slightly odd, it's not what I am used to anyway, but it's not a dealbreaker for me. I think IEEE is still a good choice. Is there another style you'd recommend?

I would vote for the APA style. Here's an example:

IEEE Style:
C. Gueymard, "Analysis of monthly average atmospheric precipitable water and turbidity in Canada and northern United States," Solar Energy, vol. 53, no. 1, pp. 57-71, 1994.

APA Style:
Gueymard, C. (1994). Analysis of monthly average atmospheric precipitable water and turbidity in Canada and northern United States. Solar Energy, 53(1), 57-71. DOI

Vote this post up if you agree with APA and vote down if you prefer IEEE.

Comment on lines +111 to +112
Other types of reference you may find in the pvlib-python documentation
include books [3]_ and technical reports [4]_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a website also.

@cwhanse
Copy link
Member

cwhanse commented Oct 11, 2024

Vote this post up if you agree with APA and vote down if you prefer IEEE.

Personally, I think the APA style is easier to read. But I'm voting for IEEE because 1) IEEE publishes the many of the references cited, 2) IEEE lets one export the citation but only in the IEEE format. If we choose APA, then I need to edit the citation rather than just copy/paste.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard citation style across docs
6 participants