Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VSCODE] Need to update to call new dockerized Windows service #4624

Closed
1 task done
jgw96 opened this issue Jan 22, 2024 · 1 comment
Closed
1 task done

[VSCODE] Need to update to call new dockerized Windows service #4624

jgw96 opened this issue Jan 22, 2024 · 1 comment
Assignees

Comments

@jgw96
Copy link
Contributor

jgw96 commented Jan 22, 2024

What happened?

We now have our new dockerized Windows service, we should call this instead of the old service for Windows packaging.

What do you expect to happen?

The new Windows service is called

What version of VS Code are you using?

No response

Relevant log output

No response

Are you using the latest version of the VS Code extension?

  • I am using the latest version of the VS Code extension
@jgw96 jgw96 self-assigned this Jan 22, 2024
@jgw96 jgw96 added this to PWABuilder Jan 22, 2024
@jgw96 jgw96 moved this to In Progress 🚧 in PWABuilder Jan 22, 2024
@jgw96 jgw96 moved this from In Progress 🚧 to In Review 🤔 in PWABuilder Jan 22, 2024
jgw96 added a commit that referenced this issue Jan 23, 2024
fixes #4624
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

 Bugfix
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->
We were calling the old Windows packaging service.

## Describe the new behavior?
We are now calling the new Windows service

## PR Checklist

- [ x] Test: run `npm run test` and ensure that all tests pass
- [ x] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ x] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information
@jgw96
Copy link
Contributor Author

jgw96 commented Feb 5, 2024

This was finished in the above PR

@jgw96 jgw96 closed this as completed Feb 5, 2024
@github-project-automation github-project-automation bot moved this from In Review 🤔 to Done ✔️ in PWABuilder Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✔️
Development

No branches or pull requests

1 participant