Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]: Ensures the contrast between foreground and background colors meets WCAG 2 AA minimum contrast ratio thresholds #4748

Closed
Suriya617 opened this issue Jun 20, 2024 · 6 comments
Assignees
Labels
A11yAuto Issues found using Accessibility Insights Tool by E+D Accessibility Team A11ySev2 Accessibility Team tag - P2 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines bug 🐛 CT-June24 HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team

Comments

@Suriya617
Copy link
Collaborator

Suriya617 commented Jun 20, 2024

What happened?

The color contrast ratio for the code text present on the page is 3.63 which is very less than expected ratio.

How do we reproduce the behavior?

Repro Steps:

  1. Open the PWA Builder URL in Anaheim dev browser.
  2. PWA Builder page will appear.
  3. Now Run the Fast Pass from AI4W.
  4. Observe the issue.

What do you expect to happen?

The color contrast ratio for the code text present on the page should be greater than or equal to 4.5:1.

What environment were you using?

Test Environment:
OS Build: Windows 11 Enterprise Insider Preview 24H2 (26120.961)
Edge Browser: Version 127.0.2651.2 (Official build) dev (64-bit)
User ID: V-
Tool: AI4W
URL: https://docs.pwabuilder.com/#/home/native-features

Additional context

Note:
Issue is repro at every URLs where code is present.

Element path:
.language-json[data-lang="json"]:nth-child(12) > .language-json > .string.token:nth-child(15)

Snippet:
"Noteworthy news from today."

How to fix:
Fix any of the following:

  • Element has insufficient color contrast of 3.2 (foreground color: #669900, background color: #f7f7f7, font size: 11.4pt (15.2px), font weight: normal). Expected contrast ratio of 4.5:1.

User Experience:
When a minimum contrast ratio is not provided between text and its background, it is difficult for low-vision users as well as anyone in extreme lighting environments to read the content.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html

Attachments:
MAS1 4 3_CCA is fail for code test

@Suriya617 Suriya617 added bug 🐛 needs triage 🔍 A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines A11ySev2 Accessibility Team tag - P2 items Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team A11yAuto Issues found using Accessibility Insights Tool by E+D Accessibility Team HCL-E+D labels Jun 20, 2024
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

2 similar comments
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@Jaylyn-Barbee Jaylyn-Barbee self-assigned this Aug 8, 2024
@Jaylyn-Barbee Jaylyn-Barbee moved this to In Review 🤔 in PWABuilder Aug 8, 2024
@Jaylyn-Barbee Jaylyn-Barbee mentioned this issue Aug 13, 2024
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 13, 2024
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

jgw96 added a commit that referenced this issue Aug 22, 2024
fixes 
- #4763
- #4748
- #4783
- #4747

<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

<!-- - Bugfix -->
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->


## Describe the new behavior?


## PR Checklist

- [ ] Test: run `npm run test` and ensure that all tests pass
- [ ] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [ ] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.


## Additional Information

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Beth Pan <[email protected]>
Co-authored-by: Gleb Khmyznikov <[email protected]>
Co-authored-by: Jaylyn Barbee <[email protected]>
Co-authored-by: Jaylyn Barbee <[email protected]>
Co-authored-by: Nikola Metulev <[email protected]>
Co-authored-by: Mara'ah Lee <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adolf Daniel <[email protected]>
Co-authored-by: Justin Willis (HE / HIM) <[email protected]>
Co-authored-by: Zach Teutsch <[email protected]>
Co-authored-by: vipul-bhojwani <[email protected]>
Co-authored-by: Amrutha Srinivasan <[email protected]>
Co-authored-by: Federico Navarrete <[email protected]>
Co-authored-by: Toby Liu <[email protected]>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Amrutha Srinivasan <[email protected]>
Co-authored-by: Jonas Thelemann <[email protected]>
Co-authored-by: Siraj Chokshi <[email protected]>
Co-authored-by: Thomas Peißl <[email protected]>
Co-authored-by: Migush <[email protected]>
Co-authored-by: Abdullhakim Sami Alshanqity <[email protected]>
Co-authored-by: mecmep <[email protected]>
Co-authored-by: Joel Limberg <[email protected]>
Co-authored-by: Pratik-k <[email protected]>
Co-authored-by: Maicon Carraro <[email protected]>
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@github-project-automation github-project-automation bot moved this from In Review 🤔 to Done ✔️ in PWABuilder Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11yAuto Issues found using Accessibility Insights Tool by E+D Accessibility Team A11ySev2 Accessibility Team tag - P2 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines bug 🐛 CT-June24 HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team
Projects
Status: Done ✔️
Development

No branches or pull requests

3 participants