Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional windows platform fields #1448

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Additional windows platform fields #1448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
950db82
Adds package language and start_url to Windows
JudahGabriel Feb 9, 2021
4a3d583
I'm writing TS, not C#
JudahGabriel Feb 9, 2021
5c8c41b
Fixed label name collision
JudahGabriel Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 45 additions & 3 deletions pages/_lang/publish.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@
</div>

<div class="form-group">
<label for="windowsStartUrlInput">
<label for="windowsUrlInput">
URL
<i
class="fas fa-info-circle"
Expand All @@ -964,7 +964,7 @@
<input
type="url"
class="form-control"
id="windowsStartUrlInput"
id="windowsUrlInput"
placeholder="/index.html"
required
v-model="windowsForm.url"
Expand All @@ -991,10 +991,30 @@
/>
</div>

<div class="form-group">
<label for="windowsStartUrlInput">
Start URL
<i
class="fas fa-info-circle"
title="Optional. The preferred URL that should be loaded when the user launches the web app. Windows will use this to determine your app's identity, so this value should not change between releases of your app. This can be an absolute or relative path."
aria-label="Optional. The preferred URL that should be loaded when the user launches the web app. Windows will use this to determine your app's identity, so this value should not change between releases of your app. This can be an absolute or relative path."
role="definition"
></i>
</label>
<input
type="url"
class="form-control"
id="windowsStartUrlInput"
placeholder="https://mysite.com/startpoint.html"
v-model="windowsForm.startUrl"
/>
jgw96 marked this conversation as resolved.
Show resolved Hide resolved
</div>

</div>

<!-- right half of the options dialog -->
<div class="col-lg-6 col-md-12">

<div class="form-group">
<label for="windowsIconUrlInput">
<a href="https://github.com/pwa-builder/pwabuilder-windows-chromium-docs/blob/master/image-recommendations.md" target="_blank">
Expand Down Expand Up @@ -1059,6 +1079,26 @@
v-model="windowsForm.publisher.commonName"
/>
</div>

<div class="form-group">
<label for="windowsLanguageInput">
Language
<i
class="fas fa-info-circle"
title="Optional. The primary language for your app package. Additional languages can be specified in Partner Center. If empty, EN-US will be used."
aria-label="Optional. The primary language for your app package. Additional languages can be specified in Partner Center. If empty, EN-US will be used."
role="definition"
></i>
</label>
<input
type="url"
class="form-control"
id="windowsLanguageInput"
placeholder="EN-US"
v-model="windowsForm.resourceLanguage"
/>
</div>

</div>
</div>
</form>
Expand Down Expand Up @@ -1847,7 +1887,9 @@ export default class extends Vue {
baseImage: icon && icon.src ? icon.src : "",
backgroundColor: "transparent",
padding: 0.3
}
},
startUrl: this.manifest.start_url,
resourceLanguage: this.manifest.lang === "en" ? "EN-US" : this.manifest.lang || ""
};

return packageOptions;
Expand Down
4 changes: 3 additions & 1 deletion store/modules/publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ export interface WindowsPackageOptions {
edgeLaunchArgs?: string;
appUserModelId?: string;
generateModernPackage?: boolean;
manifestUrl?: string;
manifestUrl?: string | null;
startUrl?: string | null;
manifest?: Manifest;
classicPackage?: {
generate?: boolean;
Expand All @@ -68,6 +69,7 @@ export interface WindowsPackageOptions {
}
images?: WindowsImageOptions;
publisher: WindowsPublisherOptions;
resourceLanguage?: string | null;
}

/**
Expand Down