Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog UI revamp #4481

Merged
merged 20 commits into from
Nov 2, 2023
Merged

Blog UI revamp #4481

merged 20 commits into from
Nov 2, 2023

Conversation

beth-panx
Copy link
Contributor

@beth-panx beth-panx commented Oct 27, 2023

fixes #4438

PR Type

  • Feature

Describe the current behavior?

Blog UI is outdated and ugly.

Describe the new behavior?

Initial pass on UI revamp. NOT including:

Needs review from:

PR Checklist

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-tree-0f6b03710-4481.centralus.azurestaticapps.net

apps/blog/src/includes/sub-header.njk Dismissed Show dismissed Hide dismissed
@beth-panx beth-panx self-assigned this Oct 27, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-tree-0f6b03710-4481.centralus.azurestaticapps.net

@beth-panx beth-panx changed the base branch from main to staging October 27, 2023 19:09
jgw96 and others added 2 commits October 30, 2023 10:35
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Gleb Khmyznikov <[email protected]>
Co-authored-by: Jaylyn Barbee <[email protected]>
Co-authored-by: Jaylyn Barbee <[email protected]>
Co-authored-by: Nikola Metulev <[email protected]>
Co-authored-by: Mara'ah Lee <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adolf Daniel <[email protected]>
Co-authored-by: Justin Willis (HE / HIM) <[email protected]>
Co-authored-by: Zach Teutsch <[email protected]>
Co-authored-by: Beth Pan <[email protected]>
Co-authored-by: vipul-bhojwani <[email protected]>
Co-authored-by: Amrutha Srinivasan <[email protected]>
Co-authored-by: Federico Navarrete <[email protected]>
Co-authored-by: Toby Liu <[email protected]>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Amrutha Srinivasan <[email protected]>
Co-authored-by: Jonas Thelemann <[email protected]>
Co-authored-by: Siraj Chokshi <[email protected]>
Co-authored-by: Thomas Peißl <[email protected]>
Copy link
Contributor

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

apps/blog/src/includes/categories.njk Outdated Show resolved Hide resolved
apps/blog/src/includes/categories.njk Outdated Show resolved Hide resolved
@beth-panx beth-panx changed the base branch from staging to main October 31, 2023 22:17
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-tree-0f6b03710-4481.centralus.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-tree-0f6b03710-4481.centralus.azurestaticapps.net

@beth-panx beth-panx changed the base branch from main to staging October 31, 2023 22:29
Copy link
Contributor

@Jaylyn-Barbee Jaylyn-Barbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, what a revamp. Looks AMAZING to me! Gonna double check accessibility quickly.

Copy link
Contributor

@Jaylyn-Barbee Jaylyn-Barbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick accessibility changes

apps/blog/src/includes/categories.njk Outdated Show resolved Hide resolved
apps/blog/src/includes/categories.njk Outdated Show resolved Hide resolved
apps/blog/src/includes/layouts/postcard.njk Outdated Show resolved Hide resolved
@beth-panx
Copy link
Contributor Author

@Jaylyn-Barbee - All accessibility comments are addressed. Feel free to approve and merge.

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Nov 2, 2023
Merged via the queue into staging with commit 55c6ed8 Nov 2, 2023
3 of 4 checks passed
@Jaylyn-Barbee Jaylyn-Barbee deleted the bethpan/blog-ui branch November 2, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BLOG] Fix funky spacing and other minor design issues on blog
3 participants