-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main to staging #4671
Merged
Merge main to staging #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Beth Pan <[email protected]> Co-authored-by: Gleb Khmyznikov <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Mara'ah Lee <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <[email protected]> Co-authored-by: Justin Willis (HE / HIM) <[email protected]> Co-authored-by: Zach Teutsch <[email protected]> Co-authored-by: vipul-bhojwani <[email protected]> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Federico Navarrete <[email protected]> Co-authored-by: Toby Liu <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Jonas Thelemann <[email protected]> Co-authored-by: Siraj Chokshi <[email protected]> Co-authored-by: Thomas Peißl <[email protected]> Co-authored-by: Migush <[email protected]> Co-authored-by: Abdullhakim Sami Alshanqity <[email protected]> Co-authored-by: mecmep <[email protected]>
…#4656) Currently, the "Start new PWA" flow results in the following error on macOS, because PWABuilder tries to create a path using Windows backslash separators. ```A system error occurred (ENOENT: no such file or directory, rename '/REDACTED\decompressedTemplate\pwa-starter-main' -> '/REDACTED\REDACTED')``` ## PR Type Bugfix Co-authored-by: Justin Willis <[email protected]>
Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
jgw96
added a commit
that referenced
this pull request
Mar 4, 2024
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Beth Pan <[email protected]> Co-authored-by: Gleb Khmyznikov <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Jaylyn Barbee <[email protected]> Co-authored-by: Nikola Metulev <[email protected]> Co-authored-by: Mara'ah Lee <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <[email protected]> Co-authored-by: Justin Willis (HE / HIM) <[email protected]> Co-authored-by: Zach Teutsch <[email protected]> Co-authored-by: vipul-bhojwani <[email protected]> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Federico Navarrete <[email protected]> Co-authored-by: Toby Liu <[email protected]> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <[email protected]> Co-authored-by: Jonas Thelemann <[email protected]> Co-authored-by: Siraj Chokshi <[email protected]> Co-authored-by: Thomas Peißl <[email protected]> Co-authored-by: Migush <[email protected]> Co-authored-by: Abdullhakim Sami Alshanqity <[email protected]> Co-authored-by: mecmep <[email protected]> Co-authored-by: Joel Limberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #[issue number]
PR Type
Describe the current behavior?
Describe the new behavior?
PR Checklist
npm run test
and ensure that all tests passAdditional Information