Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small accessibility push #4840

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Small accessibility push #4840

merged 1 commit into from
Oct 29, 2024

Conversation

Jaylyn-Barbee
Copy link
Contributor

fixes
#4762

PR Type

Bugfix

Describe the current behavior?

4762 - required fields in manifest editor are not announced as "required" by narrator

Describe the new behavior?

4762 - required fields in manifest editor are announced as "required" by narrator

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

Copy link
Contributor

Thanks Jaylyn-Barbee for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link
Contributor

@jgw96 jgw96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple fix

@jgw96 jgw96 added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit ac0c6e8 Oct 29, 2024
5 checks passed
@jgw96 jgw96 deleted the jay/acc-1024 branch October 29, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants