-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite answer objects #306
Rewrite answer objects #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a quick premature review just to point out some of the things which will need some changing. I just went through the changes really quickly and this is some of what I've noticed. There are some more little things which will also need to get addressed before this gets merged, but I didn't comment on those as this is still a work in progress PR and things will likely change anyway. I just wanted to point these things out, so they won't be forgotten about before the PR is marked as ready for review.
In that way, we also handle scenario like ```py >>> a = "'123'" >>> f"{a!r}" "'123'" >>> f"'{a}'" ''123'' ```
All conversations marked as resolved from this review
Mostly, for testing py-mine/mcstatus#306.
This PR rewrites Public API answer classes.
Breaking Changes & Migration Steps
__init__
signatures were significantly changed. If you used those, you can update to new__init__
generated by dataclasses, or usebuild
method. Although it's not something that is public API.status_response.py
.favicon
was renamed toicon
.map
attribute was renamed tomap_name
in Bedrock response class.players_online
andplayers_max
were renamed toplayers.online
andplayers.max
.version.version
was renamed toversion.name
.TODO
Base
prefix.dir
or looking in parents.What to do after the deprecation period?
TODO
comments with2023-08
mention, and do the instructions there.mcstatus.utils.deprecated
usages with2023-08
mention and remove such methods/properties.