Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement reading and writing boolean values #555

Merged
merged 9 commits into from
Jun 25, 2023
Merged

Implement reading and writing boolean values #555

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d22a05
Implement reading and writing boolean values
CoolCat467 May 28, 2023
02fb13c
Fix type annotations
CoolCat467 May 29, 2023
2c30c99
Add tests for booleans
CoolCat467 May 29, 2023
a4e73b4
Use `is` instead of `==`
CoolCat467 May 29, 2023
909e36c
Simplify boolean tests
CoolCat467 May 29, 2023
64f7e0f
Format, remove cast, and remove False literal return
CoolCat467 May 29, 2023
37fd58b
Merge branch 'py-mine:master' into master
CoolCat467 Jun 9, 2023
9676b71
Remove type annotations from context manager exit functions
CoolCat467 Jun 24, 2023
7f92695
Remove unused traceback type import
CoolCat467 Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions mcstatus/protocol/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ def write_ulong(self, value: int) -> None:
"""Write 8 bytes for value ``0 - 18446744073709551613 (2 ** 64 - 1)``."""
self.write(self._pack("Q", value))

def write_bool(self, value: bool) -> None:
"""Write 1 byte for boolean `True` or `False`"""
self.write(self._pack("?", value))

def write_buffer(self, buffer: "Connection") -> None:
"""Flush buffer, then write a varint of the length of the buffer's data, then write buffer data."""
data = buffer.flush()
Expand Down Expand Up @@ -214,6 +218,10 @@ async def write_ulong(self, value: int) -> None:
"""Write 8 bytes for value ``0 - 18446744073709551613 (2 ** 64 - 1)``."""
await self.write(self._pack("Q", value))

async def write_bool(self, value: bool) -> None:
"""Write 1 byte for boolean `True` or `False`"""
await self.write(self._pack("?", value))

async def write_buffer(self, buffer: "Connection") -> None:
"""Flush buffer, then write a varint of the length of the buffer's data, then write buffer data."""
data = buffer.flush()
Expand Down Expand Up @@ -302,6 +310,10 @@ def read_ulong(self) -> int:
"""Return ``0 - 18446744073709551613 (2 ** 64 - 1)``. Read 8 bytes."""
return self._unpack("Q", self.read(8))

def read_bool(self) -> bool:
"""Return `True` or `False`. Read 1 byte."""
return self._unpack("?", self.read(1)) == 1
CoolCat467 marked this conversation as resolved.
Show resolved Hide resolved

def read_buffer(self) -> "Connection":
"""Read a varint for length, then return a new connection from length read bytes."""
length = self.read_varint()
Expand Down Expand Up @@ -391,6 +403,10 @@ async def read_ulong(self) -> int:
"""Return ``0 - 18446744073709551613 (2 ** 64 - 1)``. Read 8 bytes."""
return self._unpack("Q", await self.read(8))

async def read_bool(self) -> bool:
"""Return `True` or `False`. Read 1 byte."""
return self._unpack("?", await self.read(1)) == 1

async def read_buffer(self) -> Connection:
"""Read a varint for length, then return a new connection from length read bytes."""
length = await self.read_varint()
Expand Down