-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop caring if the socket fails to close #56
Conversation
@Dinnerbone could you review please? |
Hmmm, it seems #51 also gets the UDP Sockets. I missed that. I will add it to mine too, in the case that a new feature is not wanted as an addition to a bugfix. |
Now @Dinnerbone would only need to answer ^^ |
|
Maybe if we are good this year, Santa will give us the gift of accepting PRs |
Or a collaborator 🙈 |
If I had a twitter account, I would shoot dinnerbone a public tweet. |
Well I just did that: https://twitter.com/MarkL4YG/status/929362396317175808 :P |
Oooooooh @Dinnerbone Wherrrrrreee are youuuuuuuuuuuuuuuuu? |
@Dinnerbone All I want for Christmaaaasssssssss is youuuuuuuuuuuuuuuuuuuuu. |
😄 I guess I'll just fork this at some point ¯\_(ツ)_/¯ |
|
Lol |
I'm still waiting to hear back from the pypi admins, but so far it seems like the suggested course of action would be to come up with a new name to publish to pypi with. pypi/warehouse#3910 |
Don't be. I'm with you. A traditional fork on GitHub and a takeover on pypi seems to be reasonable to me. |
I will publish a new version when I get home tonight. I'm excited! |
@kevinkjt2000 I am too 😉 |
contains suggested fix for issue #53