Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop caring if the socket fails to close #56

Closed
wants to merge 3 commits into from
Closed

Conversation

py-mine-bot
Copy link
Collaborator

kevinkjt2000 Authored by kevinkjt2000
Sep 4, 2017
Merged May 7, 2019


contains suggested fix for issue #53

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Sep 14, 2017


@Dinnerbone could you review please?

@py-mine-bot
Copy link
Collaborator Author

MarkL4YG Authored by MarkL4YG
Sep 15, 2017


it's good that you bring this up again but merging #51 would include your changes as @Klemek ran into these issues too

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Sep 15, 2017


Hmmm, it seems #51 also gets the UDP Sockets. I missed that. I will add it to mine too, in the case that a new feature is not wanted as an addition to a bugfix.

@py-mine-bot
Copy link
Collaborator Author

MarkL4YG Authored by MarkL4YG
Sep 15, 2017


Now @Dinnerbone would only need to answer ^^

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Sep 29, 2017


@Dinnerbone?

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Nov 10, 2017


Maybe if we are good this year, Santa will give us the gift of accepting PRs

@py-mine-bot
Copy link
Collaborator Author

MarkL4YG Authored by MarkL4YG
Nov 11, 2017


Or a collaborator 🙈

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Nov 11, 2017


If I had a twitter account, I would shoot dinnerbone a public tweet.

@py-mine-bot
Copy link
Collaborator Author

MarkL4YG Authored by MarkL4YG
Nov 11, 2017


Well I just did that: https://twitter.com/MarkL4YG/status/929362396317175808 :P

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Dec 7, 2017


Oooooooh @Dinnerbone Wherrrrrreee are youuuuuuuuuuuuuuuuu?

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Dec 18, 2017


@Dinnerbone All I want for Christmaaaasssssssss is youuuuuuuuuuuuuuuuuuuuu.
https://youtu.be/yXQViqx6GMY?t=38s

@py-mine-bot
Copy link
Collaborator Author

MarkL4YG Authored by MarkL4YG
Dec 19, 2017


😄 I guess I'll just fork this at some point ¯\_(ツ)_/¯

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
Feb 1, 2018


image

@py-mine-bot
Copy link
Collaborator Author

ghost Authored by ghost
Jun 17, 2018


Lol

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
May 3, 2019


I'm still waiting to hear back from the pypi admins, but so far it seems like the suggested course of action would be to come up with a new name to publish to pypi with. pypi/warehouse#3910
Honestly, since I've been waiting a year and a half or so, I'm tempted to just give up.

@py-mine-bot
Copy link
Collaborator Author

MarkL4YG Authored by MarkL4YG
May 4, 2019


Don't be. I'm with you. A traditional fork on GitHub and a takeover on pypi seems to be reasonable to me.
The original author is still clearly visible but project maintenance and updates can continue.

@py-mine-bot
Copy link
Collaborator Author

kevinkjt2000 Authored by kevinkjt2000
May 7, 2019


I will publish a new version when I get home tonight. I'm excited!

@py-mine-bot
Copy link
Collaborator Author

MarkL4YG Authored by MarkL4YG
May 8, 2019


@kevinkjt2000 I am too 😉

@py-mine-bot py-mine-bot added the Github Import This was auto-imported from upstream repository label Feb 16, 2022
@py-mine-bot py-mine-bot deleted the pr56head branch February 17, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github Import This was auto-imported from upstream repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants