Fixing links in table cells - close #1031

py-pdf · Nov 20, 2023 · fc044db · fc044db
1 parent 1aa87bf
commit fc044db
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/continuous-integration-workflow.yml b/.github/workflows/continuous-integration-workflow.yml
@@ -24,11 +24,11 @@ jobs:
           python-version: ${{ matrix.python-version }}
       - name: Install system dependencies ⚙️
         if: matrix.platform == 'ubuntu-latest'
-        run: sudo apt-get update && sudo apt-get install ghostscript libjpeg-dev
+        run: sudo apt-get update --allow-releaseinfo-change && sudo apt-get install ghostscript libjpeg-dev
       - name: Install qpdf ⚙️
         if: matrix.platform == 'ubuntu-latest' && matrix.python-version != '3.9'
         # We run the unit tests WITHOUT qpdf for a single parallel execution / Python version:
-        run: sudo apt-get update && sudo apt-get install qpdf
+        run: sudo apt-get update --allow-releaseinfo-change && sudo apt-get install qpdf
       - name: Install Python dependencies ⚙️
         run: |
           python -m pip install --upgrade pip setuptools wheel

diff --git a/docs/Tables.md b/docs/Tables.md
@@ -288,7 +288,7 @@ Result:
 ## Adding links to cells
 
 ```python
-                    row.cell(..., link="https://py-pdf.github.io/fpdf2/")
+row.cell(..., link="https://py-pdf.github.io/fpdf2/")
 row.cell(..., link=pdf.add_link(page=1))
 ```
 

diff --git a/fpdf/__init__.py b/fpdf/__init__.py
@@ -8,6 +8,7 @@
 * `fpdf.enums.XPos`
 * `fpdf.enums.YPos`
 * `fpdf.errors.FPDFException`
+* `fpdf.fonts.FontFace`
 * `fpdf.fpdf.TitleStyle`
 * `fpdf.prefs.ViewerPreferences`
 * `fpdf.template.Template`
@@ -24,6 +25,7 @@
     FPDF_FONT_DIR as _FPDF_FONT_DIR,
     FPDF_VERSION as _FPDF_VERSION,
 )
+from .fonts import FontFace
 from .html import HTMLMixin, HTML2FPDF
 from .prefs import ViewerPreferences
 from .template import Template, FlexTemplate
@@ -51,6 +53,7 @@
     # Classes:
     "FPDF",
     "FPDFException",
+    "FontFace",
     "Align",
     "TextMode",
     "XPos",

diff --git a/fpdf/table.py b/fpdf/table.py
@@ -464,6 +464,7 @@ def _render_table_cell(
                     output=MethodReturnValue.PAGE_BREAK | MethodReturnValue.HEIGHT,
                     wrapmode=self._wrapmode,
                     padding=padding,
+                    link=cell.link,
                     **kwargs,
                 )
 

diff --git a/test/table/table_with_links.pdf b/test/table/table_with_links.pdf