Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ul_bullet_color parameter for FPDF.write_html() #1126

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

Lucas-C
Copy link
Member

@Lucas-C Lucas-C commented Feb 28, 2024

Feature requested in #1056

Checklist:

  • The GitHub pipeline is OK (green), meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (e85ec4e) to head (e98db5d).

❗ Current head e98db5d differs from pull request most recent head 32198c7. Consider uploading reports for the commit 32198c7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1126   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          30       30           
  Lines        9130     9130           
  Branches     2071     2074    +3     
=======================================
  Hits         8530     8530           
  Misses        371      371           
  Partials      229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lucas-C Lucas-C merged commit 15af379 into master Feb 28, 2024
13 checks passed
@Lucas-C Lucas-C deleted the ul_bullet_color branch February 28, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants