Bugfix to preserve numeric values when using CSV based templates #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution and welcome @syrenius ! 😊 Please, could you provide a unit test, |
|
google suggests using pandas to parse csv data preserving the original data type, but i think thats overkill. I did figure out where the problem is, and i think we may want to instead of handling this as a general csv problem, handle it in the specific instances where the below can cause an issue: |
|
I @syrenius ! I noticed you are a newcomer here on GitHub. Feel free to ask all the questions you have regarding how things work: Regards 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the template fro a CSV file, all values in the elements dictionary end up as strings wich in turn causes problems with some other functions that rely on mathematical operators (e.g. the
rgb(col)function). This is a quick fix to try to preserve numeric values.